[net_put] - Mark scp deprecated and add check_destination

[KB-perByte]

SUMMARY

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[RobinBeismann]

Hi @rohitthakur2590, @KB-perByte any chance of getting this merged? SCP will indeed be needed for quite a while; even if the current Cisco Access Switches (C9200/C9300) will get support for SFTP; older but still supported generations as C2960X will not.

[KB-perByte]

@RobinBeismann I am working on getting this merged.
Merging it is not the hard part finding relevance of the PR is. As of now just for Cisco IOS XE appliance this PR makes sense.

@timway We would not deprecate scp from netcommon right away. But moving forward, paramiko being deprecated and libssh deprecating scp netcommon won't really have any option to continue supporting scp.

Regards.

[timway]

@timway We would not deprecate scp from netcommon right away. But moving forward, paramiko being deprecated and libssh deprecating scp netcommon won't really have any option to continue supporting scp.

Regards.

@KB-perByte do you have a link documenting the deprecation and timeline associated with that deprecation in libssh?

Also, I'm hesitant on this PR as it doesn't resolve the issue with the Cisco SSH server closing connections on a retrieving the file as part of the checking if the task is idempotent. I've started a PR in !729 to address that and a few other items.