Skip to content

Add Support for Updating in iam_server_certificate by Deleting and Creating #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Support for Updating in iam_server_certificate by Deleting and Creating #2105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0f0ce
fix error in module iam_server_certificate for _compare_cert
andrewjroth Jun 14, 2024
7184e02
add support for updating in iam_server_certificate by deleting and re…
andrewjroth Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions plugins/modules/iam_server_certificate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
short_description: Manage IAM server certificates for use on ELBs and CloudFront
description:
- Allows for the management of IAM server certificates.
- If a certificate already exists matching the name, but the certificate or chain is different,
the certificate will be deleted and recreated. This will result in the same
I(ServerCertificateName) and I(Arn), but the I(ServerCertificateId) may be different.
options:
name:
description:
Expand Down Expand Up @@ -137,34 +140,30 @@ def _compare_cert(cert_a, cert_b):
# Trim out the whitespace before comparing the certs. While this could mean
# an invalid cert 'matches' a valid cert, that's better than some stray
# whitespace breaking things
cert_a.replace("\r", "")
cert_a.replace("\n", "")
cert_a.replace(" ", "")
cert_b.replace("\r", "")
cert_b.replace("\n", "")
cert_b.replace(" ", "")
cert_a = cert_a.replace("\r", "").replace("\n", "").replace(" ", "")
cert_b = cert_b.replace("\r", "").replace("\n", "").replace(" ", "")

return cert_a == cert_b


def update_server_certificate(current_cert):
changed = False
need_update = False
cert = module.params.get("cert")
cert_chain = module.params.get("cert_chain")

if not _compare_cert(cert, current_cert.get("certificate_body", None)):
module.fail_json(msg="Modifying the certificate body is not supported by AWS")
need_update = True
if not _compare_cert(cert_chain, current_cert.get("certificate_chain", None)):
module.fail_json(msg="Modifying the chaining certificate is not supported by AWS")
# We can't compare keys.
need_update = True

if module.check_mode:
return changed
return need_update

# For now we can't make any changes. Updates to tagging would go here and
# update 'changed'
if need_update:
return delete_server_certificate(current_cert) and \
create_server_certificate()

return changed
return False


def create_server_certificate():
Expand Down