Skip to content

test: fix tessellation tests #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

test: fix tessellation tests #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
32f7a8b
update tests to match new nuget package
jacobrkerstetter Oct 23, 2025
b918a72
chore: adding changelog file 2341.test.md [dependabot-skip]
pyansys-ci-bot Oct 23, 2025
c753b6b
Merge branch 'main' into test/fix_tessellation_tests
RobPasMue Oct 29, 2025
65c5cab
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
jacobrkerstetter Oct 29, 2025
2f75b20
fixing find logos
jacobrkerstetter Oct 29, 2025
cd96bf7
Merge branch 'test/fix_tessellation_tests' of https://github.com/ansy…
jacobrkerstetter Oct 29, 2025
4202460
fix find_and_remove_logos
jacobrkerstetter Oct 29, 2025
3ed5c2a
Merge branch 'main' into test/fix_tessellation_tests
RobPasMue Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/2341.test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix tessellation tests
8 changes: 4 additions & 4 deletions src/ansys/geometry/core/tools/prepare_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,9 @@ def find_logos(
bodies = [] if bodies is None else bodies

# Convert the height inputs to Distance if they are not already
if min_height:
if min_height is not None:
min_height = min_height if isinstance(min_height, Distance) else Distance(min_height)
if max_height:
if max_height is not None:
max_height = max_height if isinstance(max_height, Distance) else Distance(max_height)

response = self._grpc_client._services.prepare_tools.find_logos(
Expand Down Expand Up @@ -432,9 +432,9 @@ def find_and_remove_logos(
bodies = [] if bodies is None else bodies

# Convert the height inputs to Distance if they are not already
if min_height:
if min_height is not None:
min_height = min_height if isinstance(min_height, Distance) else Distance(min_height)
if max_height:
if max_height is not None:
max_height = max_height if isinstance(max_height, Distance) else Distance(max_height)

response = self._grpc_client._services.prepare_tools.find_and_remove_logos(
Expand Down
24 changes: 12 additions & 12 deletions tests/integration/test_tessellation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ def test_body_tessellate(modeler: Modeler):
assert blocks_2.n_blocks == 3
if not BackendType.is_core_service(modeler.client.backend_type):
assert blocks_2.bounds == pytest.approx(
[0.019999999999999997, 0.04, 0.020151922469877917, 0.03984807753012208, 0.0, 0.03],
[0.019999999999999997, 0.04, 0.02000513783799312, 0.03999486216200688, 0.0, 0.03],
rel=1e-6,
abs=1e-8,
)
else:
assert blocks_2.bounds == pytest.approx(
[0.019999999999999997, 0.04, 0.020151922469877917, 0.03984807753012208, 0.0, 0.03],
[0.019999999999999997, 0.04, 0.02000513783799312, 0.03999486216200688, 0.0, 0.03],
rel=1e-6,
abs=1e-8,
)
Expand All @@ -93,13 +93,13 @@ def test_body_tessellate(modeler: Modeler):
mesh_2 = body_2.tessellate(merge=True)
if not BackendType.is_core_service(modeler.client.backend_type):
assert "PolyData" in str(mesh_2)
assert mesh_2.n_cells == 72
assert mesh_2.n_points == 76
assert mesh_2.n_cells == 392
assert mesh_2.n_points == 396
assert mesh_2.n_arrays == 0
else:
assert "PolyData" in str(mesh_2)
assert mesh_2.n_cells == 72
assert mesh_2.n_points == 76
assert mesh_2.n_cells == 392
assert mesh_2.n_points == 396
assert mesh_2.n_arrays == 0

# Make sure instance body tessellation is the same as original
Expand Down Expand Up @@ -199,20 +199,20 @@ def test_component_tessellate(modeler: Modeler):
comp.plot()
assert "PolyData" in str(mesh)
if not BackendType.is_core_service(modeler.client.backend_type):
assert mesh.n_cells == 3280
assert mesh.n_cells == 976
assert mesh.n_arrays == 0
assert mesh.n_points == 3300
assert mesh.n_points == 996
assert mesh.bounds == pytest.approx(
[-25.0, 25.0, -24.999251562526105, 24.999251562526105, 0.0, 20.0],
[-25.0, 25.0, -24.991140278086316, 24.991140278086316, 0.0, 20.0],
rel=1e-6,
abs=1e-8,
)
else:
assert mesh.n_cells == 3280
assert mesh.n_cells == 976
assert mesh.n_arrays == 0
assert mesh.n_points == 3300
assert mesh.n_points == 996
assert mesh.bounds == pytest.approx(
[-25.0, 25.0, -24.999251562526105, 24.999251562526105, 0.0, 20.0],
[-25.0, 25.0, -24.991140278086316, 24.991140278086316, 0.0, 20.0],
rel=1e-6,
abs=1e-8,
)
Expand Down
Loading