-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add Named Selections query to geometric entities #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobrkerstetter
wants to merge
18
commits into
main
Choose a base branch
from
feat/add_ns_to_geometric_entities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bb2d14b
wip - vertex has error
jacobrkerstetter cba074d
removing debug statements
jacobrkerstetter f5c5581
added design point and components get_named_selections functions
jacobrkerstetter f661026
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
jacobrkerstetter 40a65cf
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] ca0e812
chore: adding changelog file 2356.added.md [dependabot-skip]
pyansys-ci-bot 2e0c925
fix precommit failures
jacobrkerstetter a22c4d2
Merge branch 'feat/add_ns_to_geometric_entities' of https://github.co…
jacobrkerstetter 7f1358f
Merge branch 'main' into feat/add_ns_to_geometric_entities
jacobrkerstetter 038d2e7
remove print statements from tests
jacobrkerstetter 323b6dc
fix backwards compat
jacobrkerstetter c87f8be
fix backwards compat tests
jacobrkerstetter 843cf03
Merge branch 'main' into feat/add_ns_to_geometric_entities
RobPasMue 00ff398
wip - resolving comments
jacobrkerstetter 820b0ba
fix docstrings
jacobrkerstetter 5442275
adding design point to get_assembly
jacobrkerstetter 68f0981
add design points from get assembly and remove None type from design …
jacobrkerstetter 9306c1b
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add Named Selections query to geometric entities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,7 @@ | |
| from pyvista import MultiBlock, PolyData | ||
|
|
||
| from ansys.geometry.core.designer.component import Component | ||
| from ansys.geometry.core.designer.selection import NamedSelection | ||
|
|
||
| # TODO: Temporary fix for boolean operations | ||
| # This is a temporary fix for the boolean operations issue. The issue is that the | ||
|
|
@@ -572,6 +573,17 @@ def copy(self, parent: "Component", name: str = None) -> "Body": | |
| """ | ||
| return | ||
|
|
||
| @abstractmethod | ||
| def get_named_selections(self) -> list["NamedSelection"]: | ||
| """Get the named selections associated with the body. | ||
|
|
||
| Returns | ||
| ------- | ||
| list[NamedSelection] | ||
| List of named selections associated with the body. | ||
| """ | ||
| return | ||
|
|
||
| @abstractmethod | ||
| def get_raw_tessellation( | ||
| self, | ||
|
|
@@ -1052,6 +1064,7 @@ def _get_vertices_from_id(self, body: Union["Body", "MasterBody"]) -> list[Verte | |
| Vertex( | ||
| vertex_resp.get("id"), | ||
| vertex_resp.get("position"), | ||
| body, | ||
| ) | ||
| for vertex_resp in response.get("vertices") | ||
| ] | ||
|
|
@@ -1279,6 +1292,16 @@ def copy(self, parent: "Component", name: str = None) -> "Body": # noqa: D102 | |
| "Copy method is not implemented on the MasterBody. Call this method on a body instead." | ||
| ) | ||
|
|
||
| def get_named_selections(self, body: "Body") -> list["NamedSelection"]: # noqa: D102 | ||
| named_selections = get_design_from_body(body).named_selections | ||
|
|
||
| included_ns = [] | ||
| for ns in named_selections: | ||
| if body.id in [body.id for body in ns.bodies]: | ||
| included_ns.append(ns) | ||
|
|
||
| return included_ns | ||
|
|
||
| @min_backend_version(26, 1, 0) | ||
| def get_raw_tessellation( # noqa: D102 | ||
| self, | ||
|
|
@@ -1880,6 +1903,10 @@ def copy(self, parent: "Component", name: str = None) -> "Body": # noqa: D102 | |
| body_id = f"{parent.id}/{tb.id}" if parent.parent_component else tb.id | ||
| return Body(body_id, response.get("name"), parent, tb) | ||
|
|
||
| @ensure_design_is_active | ||
| def get_named_selections(self) -> list["NamedSelection"]: # noqa: D102 | ||
| return self._template.get_named_selections(self) | ||
|
Comment on lines
+1906
to
+1908
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should probably be done at the body level. I will change this |
||
|
|
||
| @ensure_design_is_active | ||
| def get_raw_tessellation( # noqa: D102 | ||
| self, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.