-
Notifications
You must be signed in to change notification settings - Fork 24
feat: expose PropertyFieldsContainer class properly
#2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 84.43% 84.39% -0.05%
==========================================
Files 92 92
Lines 10964 10845 -119
==========================================
- Hits 9258 9153 -105
+ Misses 1706 1692 -14 |
|
@PProfizi I have some concerns about potential inconsistencies in operators API if this PR gets merged as is. Currently, from ansys.dpf import core as dpf
identical_pfc_op = dpf.Operator("compare::property_fields_container")
print(identical_pfc_op.inputs)
# Available inputs:
# - property_fields_containerA : PropertyFieldsCollection
# - property_fields_containerB : PropertyFieldsCollection
identical_pfc_op2 = dpf.operators.logic.identical_pfc()
print(identical_pfc_op2.inputs)
# Available inputs:
# - property_fields_collectionA : PropertyFieldsCollection
# - property_fields_collectionB : PropertyFieldsCollectionI am sure about how we should proceed in this case. |
You are right. When we discussed whether the property_fields_container was exposed already, we concluded that it was not, but there are actually some operators which expose it at least as output types and thus pin names... |
PProfizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Moe, just a few comments!
…ainer (#2829) Co-authored-by: moe-ad <68085496+moe-ad@users.noreply.github.com>
Co-authored-by: Paul Profizi <100710998+PProfizi@users.noreply.github.com>
|
Some tests with 'continue-on-error: true' have failed:
|
Closes #2152, Closes #2142.
Summary
_MockPropertyFieldsContainerclass removed.PropertyFieldsContainerclass added. This subclasses theCollectionclass, and no extra methods have been added at the moment.'Class DataProcessing::DpfTypeCollection<Class DataProcessing::CPropertyField>'.