maint: remove now deprecated MockPropertyFieldsContainer
#935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moe-ad
commented
Dec 17, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 85.12% 83.05% -2.07%
==========================================
Files 52 52
Lines 5224 5224
==========================================
- Hits 4447 4339 -108
- Misses 777 885 +108 🚀 New features to boost your workflow:
|
PProfizi
reviewed
Dec 17, 2025
| label_space[label_name] = int(value) | ||
| fields = self._fc.get_fields(label_space=label_space) | ||
| if isinstance(self._fc, dpf.FieldsContainer): | ||
| fields = self._fc.get_fields(label_space=label_space) |
Contributor
There was a problem hiding this comment.
@moe-ad Doesn't the FieldsContainer inherit a get_entries method from the Collection class?
If not, we should add it so we can have the same API and not need such conditional tests.
Contributor
Author
There was a problem hiding this comment.
The problem is that FieldsContainer subclasses CollectionBase directly (a superclass of Collection) where get_entries isn't available. But _get_entries is available though, but I don't think we should be calling that directly.
Contributor
|
I'll merge |
PProfizi
reviewed
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed due to ansys/pydpf-core#2816. ansys/pydpf-core#2852 also needs to be merged before this.