-
Notifications
You must be signed in to change notification settings - Fork 139
fix: update ansys-sphinx-theme version to 1.4.4 in requirements files #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request updates the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider synchronizing the versions of
ansys-mapdl-reader
andansys-tools-visualization-interface
acrosspyproject.toml
(doc extras) and the.devcontainer
requirements files for better environment consistency.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…alization-interface to 0.9.1 in requirements files
…equirements files
Not strictly needed anymore but a good practice definitely 😄 -- the snowballstemmer team just yanked their version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
- Coverage 88.29% 88.28% -0.02%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13094 13092 -2
- Misses 1736 1738 +2 🚀 New features to boost your workflow:
|
Description
Update
ansys-sphinx-theme
to 1.4.4 to mitigate CICD failure because of ansys/ansys-sphinx-theme#685Under suggestion of
sourcery-ai[bot]
I have also updated the requirements in the codespaces.Issue linked
Related to ansys/ansys-sphinx-theme#685
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Update ansys-sphinx-theme to version 1.4.4 across project requirements files to address CICD issues
Bug Fixes:
Chores: