-
Notifications
You must be signed in to change notification settings - Fork 139
fix: MapdlRuntimeError message in cwd
#3938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThe PR refines the CWD command’s runtime error to correctly escape single quotes in the exception message string. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clatapie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
- Coverage 88.27% 88.26% -0.01%
==========================================
Files 187 187
Lines 14840 14840
==========================================
- Hits 13100 13099 -1
- Misses 1740 1741 +1 🚀 New features to boost your workflow:
|
This follows @germa89's comment on https://github.com/ansys/pymapdl/pull/3895/files/d7e2653d9a2adac4b05bc528d2495f6920c8e752#r2075315154
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Bug Fixes: