refactor: splitting result file #4144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule - Updated import paths for COMPONENTS and DPFResult from ansys.mapdl.core.reader.result to ansys.mapdl.core.reader.core. - This change aligns with the new module structure and ensures consistency across the test suite.
…o DPF-based Results backend
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DPFResult class to improve maintainability by splitting it into smaller, more focused modules. The refactoring separates data access methods from plotting functionality and introduces new type definitions.
Key changes:
- Split the large
DPFResultclass into multiple modules (core.py,data.py,plotting.py,types.py,constants.py) - Created a new unified
DPFResultclass that inherits from specialized data and plotting classes - Moved type definitions and constants to dedicated modules for better organization
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_result.py |
Updated import statements to use new module structure |
src/ansys/mapdl/core/reader/types.py |
New module defining type aliases for the reader module |
src/ansys/mapdl/core/reader/plotting.py |
New module containing plotting functionality with placeholder implementation |
src/ansys/mapdl/core/reader/data.py |
New module containing data access methods moved from the original DPFResult class |
src/ansys/mapdl/core/reader/core.py |
Renamed DPFResult to DPFResultCore and moved constants/types to separate modules |
src/ansys/mapdl/core/reader/constants.py |
New module containing constants previously defined in core.py |
src/ansys/mapdl/core/reader/__init__.py |
Updated to create unified DPFResult class from specialized components |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (74.31%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4144 +/- ##
==========================================
+ Coverage 91.30% 91.35% +0.05%
==========================================
Files 189 193 +4
Lines 15698 15722 +24
==========================================
+ Hits 14333 14363 +30
+ Misses 1365 1359 -6 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking down the DPFResult class to smaller pieces for maintainability.
Issue linked
Related to #1300 and the next plotting PR.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)