feat: adding PLVAR to plot commands #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/ansys/pymapdl into feat/using-screenshot-instead-to-show-plots
…an do another PR about it
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
github-actions
bot
added
examples
10 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4204 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 193 193
Lines 15731 15710 -21
=======================================
- Hits 14364 14345 -19
+ Misses 1367 1365 -2 🚀 New features to boost your workflow:
|
Base automatically changed from
feat/using-screenshot-instead-to-show-plots
to
main
August 28, 2025 11:49
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the PLVAR command to the plot commands list and refactors the plotting functionality to use a unified screenshot approach. The main purpose is to enable PLVAR command to work with PyMAPDL's plotting infrastructure.
- Adds PLVAR to the list of recognized plot commands
- Refactors plot command handling to use
screenshot()method consistently - Improves file naming and path handling for plot downloads
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ansys/mapdl/core/mapdl_core.py | Adds PLVAR to plot commands list and refactors plot handling to use screenshot method |
| src/ansys/mapdl/core/mapdl_grpc.py | Simplifies file filtering logic using list comprehension |
| tests/test_plotting.py | Updates tests for new plotting behavior and adds PLVAR test |
| tests/test_mapdl.py | Updates screenshot test expectations for new file naming |
| examples/00-mapdl-examples/psd-vm203.py | Demonstrates PLVAR usage in example |
| doc/changelog.d/4204.added.md | Changelog entry for PLVAR addition |
| doc/changelog.d/4196.added.md | Duplicate changelog entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@pyansys-ci-bot LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptiona
As the title.
Issue linked
Close #4187
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)