Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 8, 2025

Description

Skip database tests if TEST_DB env var does not exist or it is different than "true".

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner October 8, 2025 11:15
@germa89
Copy link
Collaborator Author

germa89 commented Oct 8, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements conditional skipping of database tests based on the TEST_DB environment variable to allow more flexible test execution control.

  • Adds TEST_DB environment variable check to skip database tests when not needed
  • Implements skip logic in both test fixture and individual test function
  • Provides consistent test execution behavior based on environment configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Oct 8, 2025
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (651042d) to head (ab155ba).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4250      +/-   ##
==========================================
+ Coverage   91.20%   91.32%   +0.12%     
==========================================
  Files         193      193              
  Lines       15719    15719              
==========================================
+ Hits        14336    14356      +20     
+ Misses       1383     1363      -20     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 enabled auto-merge (squash) October 8, 2025 11:58
@germa89 germa89 merged commit 740d4f1 into main Oct 8, 2025
49 checks passed
@germa89 germa89 deleted the ci/skiping-db-unless-there-is-a-flag branch October 8, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants