-
-
Notifications
You must be signed in to change notification settings - Fork 903
feat: add open to suggestion's children #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miownag
wants to merge
1
commit into
ant-design:feature
Choose a base branch
from
miownag:feat/add_open_to_suggestion
base: feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ## zh-CN | ||
|
|
||
| 可以通过 `open` 获取面板是否为打开的状态（主要在非受控场景下使用）。比如你需要在面板打开时禁用Sender的回车提交能力。 | ||
|
|
||
| ## en-US | ||
|
|
||
| Can get the open state of the panel by `open` (mainly used in uncontrolled scenarios). For example, you need to disable the enter submit ability of the Sender when the panel is open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { Sender, Suggestion } from '@ant-design/x'; | ||
| import type { GetProp } from 'antd'; | ||
| import React from 'react'; | ||
|
|
||
| type SuggestionItems = Exclude<GetProp<typeof Suggestion, 'items'>, () => void>; | ||
|
|
||
| const suggestions: SuggestionItems = [ | ||
| { label: 'Write a report', value: 'report' }, | ||
| { label: 'Draw a picture', value: 'draw' }, | ||
| ]; | ||
|
|
||
| const Demo: React.FC = () => { | ||
| const [value, setValue] = React.useState(''); | ||
|
|
||
| return ( | ||
| <Suggestion | ||
| items={suggestions} | ||
| onSelect={(itemVal) => { | ||
| setValue(`[${itemVal}]:`); | ||
| }} | ||
| > | ||
| {({ onTrigger, onKeyDown, open }) => { | ||
| return ( | ||
| <Sender | ||
| value={value} | ||
| onChange={(nextVal) => { | ||
| if (nextVal === '/') { | ||
| onTrigger(); | ||
| } else if (!nextVal) { | ||
| onTrigger(false); | ||
| } | ||
| setValue(nextVal); | ||
| }} | ||
| // Sender will not submit when press enter if panel is open | ||
| submitType={open ? false : 'enter'} | ||
| onKeyDown={onKeyDown} | ||
| placeholder="输入 / 获取建议" | ||
| /> | ||
| ); | ||
| }} | ||
| </Suggestion> | ||
| ); | ||
| }; | ||
|
|
||
| export default Demo; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way
SuggestionItemsis typed is a bit complex and can be simplified. TheSuggestionItemtype is exported and can be imported directly. This avoids usingGetPropandExclude, making the code clearer and more maintainable.