fix: onRequest messages& isResqesting & requestPlaceholder & requestFallback #1254

kimteayon · 2025-10-21T10:01:26Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese	修复 onRequest 数据处理，接收数组处理数组，以及修复isResqesting 的多实例状态错误问题同时优化，requestPlaceholder & requestFallback回调的入参

codecov · 2025-10-21T10:01:48Z

Bundle Report

Changes will increase total bundle size by 10.04kB (0.24%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
x-markdown-array-push	3.94MB	10.04kB (0.26%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: x-markdown-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`mermaid.min.js`	10.04kB	3.94MB	0.26%

gemini-code-assist · 2025-10-21T10:01:52Z

Summary of Changes

Hello @kimteayon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the x-chat functionality by refining how messages are processed during requests, ensuring accurate state management for concurrent chat instances, and providing richer contextual information to custom callback functions. These improvements contribute to a more robust and adaptable chat component, backed by extensive new tests and updated user documentation.

Highlights

Enhanced onRequest Message Handling: The transformLocalMessage function now supports processing arrays of messages, allowing the onRequest mechanism to handle multiple messages simultaneously for greater flexibility.
Improved isRequesting State Management: A new IsRequestingMap has been introduced to accurately track the isRequesting status across multiple useXChat instances, resolving previous multi-instance state errors and ensuring correct loading indicators.
Enriched Callbacks for requestPlaceholder and requestFallback: The callback functions for requestPlaceholder and requestFallback now receive more comprehensive context, including the full requestParams and the original message, enabling more powerful and context-aware custom logic.
Expanded Test Coverage: A significant number of new unit tests have been added for OpenAIChatProvider's message transformation functions, covering various scenarios like streaming, non-streaming, function calls, and edge cases, thereby improving reliability.
Updated Documentation: The useXChat documentation has been revised to reflect the new function signatures and parameters for requestPlaceholder and requestFallback.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2025-10-21T10:01:52Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch sdk-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-21T10:02:09Z

cloudflare-workers-and-pages · 2025-10-21T10:02:33Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`74c6de8`
Status:	✅ Deploy successful!
Preview URL:	https://bacb17dd.ant-design-x.pages.dev
Branch Preview URL:	https://sdk-fix.ant-design-x.pages.dev

View logs

gemini-code-assist

Code Review

This pull request introduces several important fixes and enhancements to the useXChat hook, including per-conversation request state management, improved callback signatures for requestPlaceholder and requestFallback, and support for handling arrays of messages from transformLocalMessage. The significant expansion of test coverage is also a commendable improvement. However, I have identified two critical issues in packages/x-sdk/src/x-chat/index.ts that could lead to runtime errors and should be addressed. Additionally, there are a couple of minor documentation errors that need correction.

packages/x-sdk/src/x-chat/index.ts

packages/x/docs/x-sdk/use-x-chat.en-US.md

packages/x/docs/x-sdk/use-x-chat.zh-CN.md

github-actions · 2025-10-21T10:15:10Z

size-limit report 📦

Path	Size
`packages/x/dist/antdx.min.js`	66.75 KB
`packages/x-sdk/dist/x-sdk.min.js`	7.31 KB (+45 B 🔺)
`packages/x-markdown/dist/x-markdown.min.js`	43.51 KB
`packages/x-markdown/dist/plugins/code-high-light.min.js`	278.82 KB
`packages/x-markdown/dist/plugins/latex.min.js`	61.94 KB
`packages/x-markdown/dist/plugins/mermaid.min.js`	850.92 KB

codecov · 2025-10-21T11:33:51Z

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.95%. Comparing base (485b4a4) to head (74c6de8).
⚠️ Report is 1 commits behind head on next.

Files with missing lines	Patch %	Lines
packages/x-sdk/src/x-chat/index.ts	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1254      +/-   ##
==========================================
+ Coverage   94.89%   94.95%   +0.06%     
==========================================
  Files         138      138              
  Lines        3586     3590       +4     
  Branches     1011     1016       +5     
==========================================
+ Hits         3403     3409       +6     
+ Misses        182      180       -2     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kimteayon added 14 commits October 19, 2025 01:54

docs: x-sdk

d9eee5b

docs: x-sdk

1412928

docs: x-sdk

220d205

fix: md eror

b2a8227

feat: activeConversationKey

d4ab51e

feat: activeConversationKey

0d3a5f7

feat: activeConversationKey

b3a0414

feat: activeConversationKey

1bdb168

feat: activeConversationKey

57ef064

feat: activeConversationKey

f19b022

feat: activeConversationKey

70eb07f

docs: 更新文档

affbfc5

fix: 修复onrequest 数据处理

4553ec7

fix: 修复onrequest 数据处理

e85871f

dosubot bot added the bug Something isn't working label Oct 21, 2025

gemini-code-assist bot reviewed Oct 21, 2025

View reviewed changes

test: 修改测试用例

f8aabe3

hylin approved these changes Oct 21, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2025

feat: add

74c6de8

kimteayon merged commit d51be74 into next Oct 21, 2025
12 of 13 checks passed

kimteayon deleted the sdk-fix branch October 21, 2025 12:00

Uh oh!

fix: onRequest messages& isResqesting & requestPlaceholder & requestFallback #1254

fix: onRequest messages& isResqesting & requestPlaceholder & requestFallback #1254

Uh oh!

Conversation

kimteayon commented Oct 21, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

gemini-code-assist bot commented Oct 21, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design-x with Cloudflare Pages

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Oct 21, 2025 •

edited

Loading

coderabbitai bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 21, 2025 •

edited

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading