Itudoben improve logging filtering #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
- Trim response string once and use parameterized logging for sampler results. - Improves readability and performance by avoiding redundant substring and string formatting.
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
…ient Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
…ve parameter conversion Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
itudoben
force-pushed
the
itudoben-improve-logging-filtering
branch
from
7a72484 to
38da0ee
Compare
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Signed-off-by: Johnny Hujol <itudoben@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging for debugging purposes. Fail fast when the sample result is null or empty.
Introduce a system property to change the filter to reject !! warmup samples based on each call to handlSampleResult.