Abp 9.1.3 package update #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects and fix logging method in Tasky.AuthServer
There was a problem hiding this comment.
Pull Request Overview
This PR updates package versions across the solution to align with ABP 9.1.3 and related dependency releases, and adds Fody weaving configuration files to each project.
- Bumped numerous NuGet and npm dependencies (ABP, Microsoft.AspNetCore, Blazorise, Aspire.Hosting, etc.) to their latest patch versions.
- Introduced
FodyWeavers.xsdandFodyWeavers.xmlin each project for ConfigureAwait.Fody support. - Replaced synchronous
Log.CloseAndFlush()withawait Log.CloseAndFlushAsync()inProgram.cs.
Reviewed Changes
Copilot reviewed 98 out of 98 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gateway/Tasky.Gateway/Tasky.Gateway.csproj | Updated JwtBearer, OpenApi, Scalar, Yarp versions |
| src/apps/angular/package.json | Bumped @abp/ng.* dependencies to 9.1.3 |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Domain.Shared/Tasky.WebApp.Domain.Shared.csproj | Updated ABP domain shared and Microsoft extensions |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Domain.Shared/FodyWeavers.xsd, .xml | Added Fody configuration |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Blazor/Tasky.WebApp.Blazor.csproj | Bumped Blazor Server package version |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Blazor/FodyWeavers.xsd, .xml | Added Fody configuration |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Blazor.Client/Tasky.WebApp.Blazor.Client.csproj | Bumped Blazorise, ABP WebAssembly packages |
| src/apps/Tasky.WebApp/src/Tasky.WebApp.Blazor.Client/FodyWeavers.xsd, .xml | Added Fody configuration |
| src/apps/Tasky.AuthServer/package.json | Bumped ABP LeptonXLite theme |
| src/apps/Tasky.AuthServer/Tasky.AuthServer.csproj | Updated DataProtection and ABP packages |
| src/apps/Tasky.AuthServer/Program.cs | Swapped Log.CloseAndFlush() for async version |
| src/apps/Tasky.AuthServer/FodyWeavers.xsd, .xml | Added Fody configuration |
| src/apps/Tasky.AppHost/Tasky.AppHost.csproj | Bumped Aspire.Hosting packages |
| src/apps/Tasky.AppHost/FodyWeavers.xsd, .xml | Added Fody configuration |
| src/Directory.Build.props | Upgraded Fody, NetAnalyzers, VSThreading, NodaTime |
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
There’s a leading BOM (zero-width) character before the <Project> tag. Removing it will prevent potential encoding or tooling issues.
Suggested change
| <Project Sdk="Microsoft.NET.Sdk"> | |
| <Project Sdk="Microsoft.NET.Sdk"> |
Copilot uses AI. Check for mistakes.
| @@ -10,11 +10,11 @@ | |||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="ConfigureAwait.Fody" Version="3.3.2" PrivateAssets="All" /> | |||
| <PackageReference Include="Fody" Version="6.8.2"> | |||
| <PackageReference Include="Fody" Version="6.9.2"> | |||
There was a problem hiding this comment.
[nitpick] Consider centralizing common dependency versions (e.g., ABP, Fody) into MSBuild properties to simplify future upgrades and reduce duplication across projects.
Copilot uses AI. Check for mistakes.
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Nerdbank.GitVersioning" Condition="!Exists('packages.config')"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <Version>3.*</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="NodaTime" Version="$(NodaTimePackageVersion)" /> | ||
| <PackageReference Include="NodaTime" Version="3.2.2" /> |
There was a problem hiding this comment.
[nitpick] Hard-coding the NodaTime version here bypasses the $(NodaTimePackageVersion) property; consider using a property for consistency.
Suggested change
| <PackageReference Include="NodaTime" Version="3.2.2" /> | |
| <PackageReference Include="NodaTime" Version="$(NodaTimePackageVersion)" /> |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.