Handle IllegalStateException in serviceLock #5847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for determining if the lock ownership method is working or getting stuck in a loop when the createdNodeName is null.
Adds a catch statement to the lock method so the createdNodeName entry is cleaned up after the tryLock hits an illegalStateException and cannot get out of it.
keith-turner
reviewed
Sep 2, 2025
| lock(lww, data); | ||
| try { | ||
| lock(lww, data); | ||
| } catch (IllegalStateException e) { |
There was a problem hiding this comment.
Is there a specific throw in the code that this is trying to catch? Seeing a few places that throw this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a try/catch method to handle the IllegalStateException that could be thrown by the lock method.
This handler allows the cleanup operation to run which sets the createdNodeName back to null.
See the commit diff for test behavior before and after the code change.