docs: document all the missing keys #498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
commented
Sep 27, 2025
| /// <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html> | ||
| /// | ||
| /// Supported keys: | ||
| /// - `aws_container_credentials_relative_uri` |
There was a problem hiding this comment.
not sure if it is intentional that parts of the options have only the aws_ prefix, parts allow both and parts of the keys only the non-aws prefix.
This is a new feature => different issue, but if there is apetite, I can raise an PR.
I think the best way would be support both aws_suffix and suffix => the most compliant parsing.
Alternative, allowing suffix for all and aws_suffix is also a fine API
CommanderStorm
commented
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #497
Rationale for this change
The keys should either all be documented, or all undocumented.
Being partially documented is not quite ideal.
What changes are included in this PR?
The docs change, that some keys did not have docs for their "Supported keys"
Are there any user-facing changes?
Yes, this is a docs change.