-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48668: [Python][Docs] Add python examples for compute functions min/max/min_max
#48648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
min/max/min_maxmin/max/min_max
min/max/min_maxmin/max/min_max
|
|
min/max/min_maxmin/max/min_max
|
@github-actions crossbow submit preview-docs |
|
Revision: 0dd7172 Submitted crossbow builds: ursacomputing/crossbow @ actions-cf5287d610
|
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @zhengruifeng !
Oh, preview-docs is failing. Need to look into that separately.
I built the docs locally and the change renders correctly:
I do have one suggestion: as you have added examples with nulls, one of them could be selected to demonstrate the use of skip_nulls option. And similarly we could include the min_count option, maybe in form of ScalarAggregateOptions?
ec7ab66 to
408cd16
Compare
|
@github-actions crossbow submit preview-docs |
|
@AlenkaF thank you so much for the review and validation. I have updated the examples according to your suggestions, thanks! |
|
Revision: 408cd16 Submitted crossbow builds: ursacomputing/crossbow @ actions-fa4f1e4b79
|
|
@github-actions crossbow submit preview-docs |
|
Revision: 49db571 Submitted crossbow builds: ursacomputing/crossbow @ actions-2f395d3547
|
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengruifeng the preview-docs job is not working at the moment. Will open a separate issue to tackle that.
Thank you for the updates, the examples look great!
Will build the docs locally one more time before merging.
|
preview-docs failure issue tracked here: #48754 |
Rationale for this change
To improve python documentation
What changes are included in this PR?
Add python examples for compute functions
min/max/min_maxAre these changes tested?
Yes, doc-test
Are there any user-facing changes?
Doc-only changes