Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Dec 25, 2025

Rationale for this change

To improve python documentation

What changes are included in this PR?

Add python examples for compute functions min/max/min_max

Are these changes tested?

Yes, doc-test

Are there any user-facing changes?

Doc-only changes

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@zhengruifeng zhengruifeng changed the title WIP: Add python examples for compute functions min/max/min_max MINOR: [PYTHON] Add python examples for compute functions min/max/min_max Dec 26, 2025
@zhengruifeng zhengruifeng changed the title MINOR: [PYTHON] Add python examples for compute functions min/max/min_max GH-48668: [PYTHON][DOCS] Add python examples for compute functions min/max/min_max Dec 26, 2025
@github-actions
Copy link

⚠️ GitHub issue #48668 has been automatically assigned in GitHub to PR creator.

@zhengruifeng zhengruifeng marked this pull request as ready for review December 26, 2025 11:23
@AlenkaF AlenkaF changed the title GH-48668: [PYTHON][DOCS] Add python examples for compute functions min/max/min_max GH-48668: [Python][Docs] Add python examples for compute functions min/max/min_max Jan 5, 2026
@AlenkaF
Copy link
Member

AlenkaF commented Jan 5, 2026

@github-actions crossbow submit preview-docs

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Revision: 0dd7172

Submitted crossbow builds: ursacomputing/crossbow @ actions-cf5287d610

Task Status
preview-docs GitHub Actions

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @zhengruifeng !

Oh, preview-docs is failing. Need to look into that separately.
I built the docs locally and the change renders correctly:

Posnetek zaslona 2026–01–06 ob 10 27 30

I do have one suggestion: as you have added examples with nulls, one of them could be selected to demonstrate the use of skip_nulls option. And similarly we could include the min_count option, maybe in form of ScalarAggregateOptions?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 6, 2026
@zhengruifeng
Copy link
Contributor Author

@github-actions crossbow submit preview-docs

@zhengruifeng
Copy link
Contributor Author

@AlenkaF thank you so much for the review and validation. I have updated the examples according to your suggestions, thanks!

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Revision: 408cd16

Submitted crossbow builds: ursacomputing/crossbow @ actions-fa4f1e4b79

Task Status
preview-docs GitHub Actions

@zhengruifeng
Copy link
Contributor Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Revision: 49db571

Submitted crossbow builds: ursacomputing/crossbow @ actions-2f395d3547

Task Status
preview-docs GitHub Actions

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengruifeng the preview-docs job is not working at the moment. Will open a separate issue to tackle that.

Thank you for the updates, the examples look great!
Will build the docs locally one more time before merging.

@AlenkaF
Copy link
Member

AlenkaF commented Jan 7, 2026

preview-docs failure issue tracked here: #48754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants