Skip to content

Conversation

@cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Dec 25, 2025

What changes were proposed in this pull request?

Why are the changes needed?

A client that supports HARD_SPLIT in PushMergedData will report the following error when accessing a lower version of the Server.

java.nio.BufferUnderflowException
	at java.base/java.nio.Buffer.nextGetIndex(Buffer.java:713)
	at java.base/java.nio.DirectByteBuffer.get(DirectByteBuffer.java:334)
	at org.apache.celeborn.client.ShuffleClientImpl$5.onSuccess(ShuffleClientImpl.java:1430)
	at org.apache.celeborn.common.network.client.TransportResponseHandler.handle(TransportResponseHandler.java:373)
	at org.apache.celeborn.common.network.server.TransportChannelHandler.channelRead(TransportChannelHandler.java:158)

Does this PR resolve a correctness bug?

Does this PR introduce any user-facing change?

How was this patch tested?

local test

new RpcResponseCallback() {
@Override
public void onSuccess(ByteBuffer response) {
// Compatible with lower versions of Server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add more detail info here? e.g., JIRA tickets, versions, and why it can be treated as success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants