-
Notifications
You must be signed in to change notification settings - Fork 70
output: allow filtering and honour output format for non-list apis #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, filtering is not working when the response object is not returning an array. This PR makes changes to allow filtering when response object is an array or a map. For async apis, filter arg is passed to the query request allowing filtering to work with the final response. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
tested destroy
Also tried to merge it with #163 but couldn’t get that to work yet. Both look good in isolation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retested:
|
✅ Build complete for PR #164. 🔗 Download the cmk binaries (expires on August 18, 2025) |
@shwstppr , any reason not to merge this yet? |
@DaanHoogland when I checked last it had the need-testing label so I was not sure if you wanted more testing on it |
right, removed, merging |
…pache#164) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Fixes #117
Fixes #152
Currently, filtering is not working when the response object is not returning an array. This PR makes changes to allow filtering when response object is an array or a map.
For async apis, filter arg is passed to the query request allowing filtering to work with the final response.
Output with changes,
For output,