autocomplete: allow completion based on name/detail of exisiting results for parameter #165
Conversation
Fixes apache#48 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the autocomplete functionality to support completion based on both the value and detail fields of completion items, addressing issue #48. The changes allow users to trigger autocompletion by typing either the main value or the detail portion of completion options.
- Modified filtering logic to include items where the detail field matches the input prefix
- Updated option display logic to show full option when matching on detail field
- Changed condition for showing details from requiring multiple options to showing when any detail exists
| @@ -421,12 +421,14 @@ func (t *autoCompleter) Do(line []rune, pos int) (options [][]rune, offset int) | |||
| } | |||
| for _, item := range filteredOptions { | |||
| option := item.Value + " " | |||
| if len(filteredOptions) > 1 && len(item.Detail) > 0 { | |||
| if len(filteredOptions) > 0 && len(item.Detail) > 0 { | |||
There was a problem hiding this comment.
[nitpick] The condition change from > 1 to > 0 means details will now always be shown when they exist, even for single options. This could clutter the display unnecessarily. Consider if this change aligns with the intended UX behavior.
| if len(filteredOptions) > 0 && len(item.Detail) > 0 { | |
| if len(filteredOptions) > 1 && len(item.Detail) > 0 { |
Copilot uses AI. Check for mistakes.
| option += fmt.Sprintf("(%v)", item.Detail) | ||
| } | ||
| if strings.HasPrefix(option, argInput) { | ||
| options = append(options, []rune(option[len(argInput):])) | ||
| offset = len(argInput) | ||
| } else if len(item.Detail) > 0 && strings.HasPrefix(item.Detail, argInput) { | ||
| options = append(options, []rune(option)) |
There was a problem hiding this comment.
When matching on detail, the full option string is returned without adjusting the offset. This means the completion will include the entire option text, potentially overwriting the user's input. The offset should be set to 0 when returning the full option.
| options = append(options, []rune(option)) | |
| options = append(options, []rune(option)) | |
| offset = 0 |
Copilot uses AI. Check for mistakes.
|
✅ Build complete for PR #165. 🔗 Download the cmk binaries (expires on August 30, 2025) |
There was a problem hiding this comment.
LGTM , Deploy 2 vms( vm1, vm2) , 2 networks (tier1, tier2)
Before fix autocompletion for the vmname was not working
(admin) 🐱 > list virtualmachines id=v
(admin) 🐱 > list networks id=t
After fix
bin/cmk
(admin) 🐱 > list virtualmachines id=v
0782866e-2c93-4c33-9434-05506e63ed0a (vm1) 80f8201f-794d-4d44-b934-6794df000388 (vm2)
(admin) 🐱 > list networks id=t
8e5d9efd-8bd2-452c-b004-77537f059590 (tier2) d6b6622e-8ed4-4c5e-84c2-e038c14f2d9a (tier1)
|
This is a good to have. If we are confident with testing we can include it in 6.5.0 milestone. |
shwstppr
changed the title
shwstppr
changed the title
There was a problem hiding this comment.
LGTM, Tested various List api calls
https://cloudstack.apache.org/api/apidocs-4.20/
The autocompletion works fine on the existing results of a parameter
Fixes #48
cmk-name-autocompletion.mp4