-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: show usage server restart message on usage config change #11969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Conversation
Fixes apache#10853 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11969 +/- ##
=========================================
Coverage 17.56% 17.56%
- Complexity 15540 15544 +4
=========================================
Files 5909 5909
Lines 529045 529058 +13
Branches 64615 64617 +2
=========================================
+ Hits 92933 92947 +14
+ Misses 425657 425656 -1
Partials 10455 10455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
verified in qa.c.c |
Description
Fixes #10853
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?