Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions benchmarks/bench.sh
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ imdb: Join Order Benchmark (JOB) using the IMDB dataset conver

# Micro-Benchmarks (specific operators and features)
cancellation: How long cancelling a query takes
nlj: Benchmark for simple nested loop joins, testing various join scenarios

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Supported Configuration (Environment Variables)
Expand Down Expand Up @@ -187,6 +188,7 @@ main() {
data_clickbench_1
data_clickbench_partitioned
data_imdb
# nlj uses range() function, no data generation needed
;;
tpch)
data_tpch "1"
Expand Down Expand Up @@ -261,6 +263,10 @@ main() {
# same data as for tpch
data_tpch "1"
;;
nlj)
# nlj uses range() function, no data generation needed
echo "NLJ benchmark does not require data generation"
;;
*)
echo "Error: unknown benchmark '$BENCHMARK' for data generation"
usage
Expand Down Expand Up @@ -317,6 +323,7 @@ main() {
run_h2o_join "BIG" "PARQUET" "join"
run_imdb
run_external_aggr
run_nlj
;;
tpch)
run_tpch "1" "parquet"
Expand Down Expand Up @@ -393,6 +400,9 @@ main() {
topk_tpch)
run_topk_tpch
;;
nlj)
run_nlj
;;
*)
echo "Error: unknown benchmark '$BENCHMARK' for run"
usage
Expand Down Expand Up @@ -1020,6 +1030,14 @@ run_topk_tpch() {
$CARGO_COMMAND --bin dfbench -- sort-tpch --iterations 5 --path "${TPCH_DIR}" -o "${RESULTS_FILE}" --limit 100 ${QUERY_ARG}
}

# Runs the nlj benchmark
run_nlj() {
RESULTS_FILE="${RESULTS_DIR}/nlj.json"
echo "RESULTS_FILE: ${RESULTS_FILE}"
echo "Running nlj benchmark..."
debug_run $CARGO_COMMAND --bin dfbench -- nlj --iterations 5 -o "${RESULTS_FILE}" ${QUERY_ARG}
}


compare_benchmarks() {
BASE_RESULTS_DIR="${SCRIPT_DIR}/results"
Expand Down
4 changes: 3 additions & 1 deletion benchmarks/src/bin/dfbench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
#[global_allocator]
static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;

use datafusion_benchmarks::{cancellation, clickbench, h2o, imdb, sort_tpch, tpch};
use datafusion_benchmarks::{cancellation, clickbench, h2o, imdb, nlj, sort_tpch, tpch};

#[derive(Debug, StructOpt)]
#[structopt(about = "benchmark command")]
Expand All @@ -42,6 +42,7 @@ enum Options {
Clickbench(clickbench::RunOpt),
H2o(h2o::RunOpt),
Imdb(imdb::RunOpt),
Nlj(nlj::RunOpt),
SortTpch(sort_tpch::RunOpt),
Tpch(tpch::RunOpt),
TpchConvert(tpch::ConvertOpt),
Expand All @@ -57,6 +58,7 @@ pub async fn main() -> Result<()> {
Options::Clickbench(opt) => opt.run().await,
Options::H2o(opt) => opt.run().await,
Options::Imdb(opt) => Box::pin(opt.run()).await,
Options::Nlj(opt) => opt.run().await,
Options::SortTpch(opt) => opt.run().await,
Options::Tpch(opt) => Box::pin(opt.run()).await,
Options::TpchConvert(opt) => opt.run().await,
Expand Down
1 change: 1 addition & 0 deletions benchmarks/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ pub mod cancellation;
pub mod clickbench;
pub mod h2o;
pub mod imdb;
pub mod nlj;
pub mod sort_tpch;
pub mod tpch;
pub mod util;
244 changes: 244 additions & 0 deletions benchmarks/src/nlj.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,244 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::util::{BenchmarkRun, CommonOpt, QueryResult};
use datafusion::{error::Result, prelude::SessionContext};
use datafusion_common::exec_datafusion_err;
use datafusion_common::instant::Instant;
use structopt::StructOpt;

/// Run the Nested Loop Join (NLJ) benchmark
///
/// This micro-benchmark focuses on the performance characteristics of NLJs.
///
/// It always tries to use fast scanners (without decoding overhead) and
/// efficient predicate expressions to ensure it can reflect the performance
/// of the NLJ operator itself.
///
/// In this micro-benchmark, the following workload characteristics will be
/// varied:
/// - Join type: Inner/Left/Right/Full (all for the NestedLoopJoin physical
/// operator)
/// TODO: Include special join types (Semi/Anti/Mark joins)
/// - Input size: Different combinations of left (build) side and right (probe)
/// side sizes
/// - Selectivity of join filters
#[derive(Debug, StructOpt, Clone)]
#[structopt(verbatim_doc_comment)]
pub struct RunOpt {
/// Query number (between 1 and 10). If not specified, runs all queries
#[structopt(short, long)]
query_name: Option<String>,

/// Common options
#[structopt(flatten)]
common: CommonOpt,

/// If present, write results json here
#[structopt(parse(from_os_str), short = "o", long = "output")]
output_path: Option<std::path::PathBuf>,
}

/// Inline SQL queries for NLJ benchmarks
///
/// Each query's comment includes:
/// - Left (build) side row count × Right (probe) side row count
/// - Join predicate selectivity (1% means the output size is 1% * input size)
const NLJ_QUERIES: &[&str] = &[
// Q1: INNER 10K x 10K | LOW 0.1%
r#"
SELECT *
FROM range(10000) AS t1
JOIN range(10000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q2: INNER 10K x 10K | Medium 20%
r#"
SELECT *
FROM range(10000) AS t1
JOIN range(10000) AS t2
ON (t1.value + t2.value) % 5 = 0;
"#,
// Q3: INNER 10K x 10K | High 90%
r#"
SELECT *
FROM range(10000) AS t1
JOIN range(10000) AS t2
ON (t1.value + t2.value) % 10 <> 0;
"#,
// Q4: INNER 30K x 30K | Medium 20%
r#"
SELECT *
FROM range(30000) AS t1
JOIN range(30000) AS t2
ON (t1.value + t2.value) % 5 = 0;
"#,
// Q5: INNER 10K x 200K | LOW 0.1% (small to large)
r#"
SELECT *
FROM range(10000) AS t1
JOIN range(200000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q6: INNER 200K x 10K | LOW 0.1% (large to small)
r#"
SELECT *
FROM range(200000) AS t1
JOIN range(10000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q7: RIGHT OUTER 10K x 200K | LOW 0.1%
r#"
SELECT *
FROM range(10000) AS t1
RIGHT JOIN range(200000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q8: LEFT OUTER 200K x 10K | LOW 0.1%
r#"
SELECT *
FROM range(200000) AS t1
LEFT JOIN range(10000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q9: FULL OUTER 30K x 30K | LOW 0.1%
r#"
SELECT *
FROM range(30000) AS t1
FULL JOIN range(30000) AS t2
ON (t1.value + t2.value) % 1000 = 0;
"#,
// Q10: FULL OUTER 30K x 30K | High 90%
r#"
SELECT *
FROM range(30000) AS t1
FULL JOIN range(30000) AS t2
ON (t1.value + t2.value) % 10 <> 0;
"#,
];

impl RunOpt {
pub async fn run(self) -> Result<()> {
println!("Running NLJ benchmarks with the following options: {self:#?}\n");

// Define available queries
let available_queries =
vec!["q1", "q2", "q3", "q4", "q5", "q6", "q7", "q8", "q9", "q10"];
let query_list = match &self.query_name {
Some(query_name) => {
if available_queries.contains(&query_name.as_str()) {
vec![query_name.as_str()]
} else {
return Err(exec_datafusion_err!(
"Query '{}' not found. Available queries: {:?}",
query_name,
available_queries
));
}
}
None => available_queries,
};

let config = self.common.config()?;
let rt_builder = self.common.runtime_env_builder()?;
let ctx = SessionContext::new_with_config_rt(config, rt_builder.build_arc()?);

let mut benchmark_run = BenchmarkRun::new();
for query_name in query_list {
let query_index = match query_name {
"q1" => 0,
"q2" => 1,
"q3" => 2,
"q4" => 3,
"q5" => 4,
"q6" => 5,
"q7" => 6,
"q8" => 7,
"q9" => 8,
"q10" => 9,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can rewrite it as follows to avoid this match and available_queries.

let query_range = match self.query {
Some(query_id) => query_id..=query_id,
None => IMDB_QUERY_START_ID..=IMDB_QUERY_END_ID,
};
let mut benchmark_run = BenchmarkRun::new();
for query_id in query_range {

let query_range = match self.query {
    Some(query_id) => query_id..=query_id,
    None => 1..=NLJ_QUERIES.len(),
};

for query_id in query_range {
    // ...
    let sql = NLJ_QUERIES[query_id-1];
    // ...
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in a3f5d05

_ => {
if self.query_name.is_some() {
return Err(exec_datafusion_err!(
"Could not find query '{}'.",
query_name
));
}
continue;
}
};

let sql = NLJ_QUERIES[query_index];
benchmark_run.start_new_case(&format!("Query {query_name}"));
let query_run = self.benchmark_query(sql, query_name, &ctx).await;
match query_run {
Ok(query_results) => {
for iter in query_results {
benchmark_run.write_iter(iter.elapsed, iter.row_count);
}
}
Err(e) => {
eprintln!("Query {query_name} failed: {e}");
benchmark_run.write_iter(std::time::Duration::from_secs(0), 0);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return Err(e) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a3f5d05

}
}

benchmark_run.maybe_write_json(self.output_path.as_ref())?;
Ok(())
}

/// Validates that the query's physical plan uses a NestedLoopJoin (NLJ),
/// then executes the query and collects execution times.
///
/// TODO: ensure the optimizer won't change the join order (it's not at
/// v48.0.0).
async fn benchmark_query(
&self,
sql: &str,
query_name: &str,
ctx: &SessionContext,
) -> Result<Vec<QueryResult>> {
let mut query_results = vec![];

// Validate that the query plan includes a Nested Loop Join
let df = ctx.sql(sql).await?;
let physical_plan = df.create_physical_plan().await?;
let plan_string = format!("{physical_plan:#?}");

if !plan_string.contains("NestedLoopJoinExec") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

return Err(exec_datafusion_err!(
"Query {query_name} does not use Nested Loop Join. Physical plan: {plan_string}"
));
}

for i in 0..self.common.iterations {
let start = Instant::now();
let df = ctx.sql(sql).await?;
let batches = df.collect().await?;
let elapsed = start.elapsed(); //.as_secs_f64() * 1000.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's meaning of //.as_secs_f64() * 1000.0;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in a3f5d05 to avoid confusion.


let row_count = batches.iter().map(|b| b.num_rows()).sum();
println!(
"Query {query_name} iteration {i} returned {row_count} rows in {elapsed:?}"
);

query_results.push(QueryResult { elapsed, row_count });
}

Ok(query_results)
}
}