feat(spark): implement Spark datetime function last_day #16828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alamb, I’ve added the |
I think the issue is that the function is named fn name(&self) -> &str {
"spark_last_day"
} |
2010YOUY01
reviewed
Jul 22, 2025
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
|
|
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* feat(spark): implement Spark datetime function last_day Signed-off-by: Alan Tang <jmtangcs@gmail.com> * chore: fix the export function name Signed-off-by: Alan Tang <jmtangcs@gmail.com> * chore: Fix Cargo.toml formatting Signed-off-by: Alan Tang <jmtangcs@gmail.com> * test: add more tests for spark function last_day Signed-off-by: Alan Tang <jmtangcs@gmail.com> * feat(spark): set the signature to be taking exactly one Date32 type Signed-off-by: Alan Tang <jmtangcs@gmail.com> * test(spark): add more bad cases Signed-off-by: Alan Tang <jmtangcs@gmail.com> * chore: clean up redundant package Signed-off-by: Alan Tang <jmtangcs@gmail.com> --------- Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datetimefunctionlast_day#16774.datafusion-sparkSpark Compatible Functions #15914.Rationale for this change
What changes are included in this PR?
Implement Spark datetime function last_day
Are these changes tested?
I added tests for
last_dayfunction.Are there any user-facing changes?
yes, new function.