Skip to content

Minor: Optimize byte view benchmark to add more groups and more testing cases. #16862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Minor: Optimize byte view benchmark to add more groups and more testing cases. #16862

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccbcd59
minor: optimize byte_view_bench and add more cases
zhuqi-lucas-001 Jul 23, 2025
eb3b1d3
fix
zhuqi-lucas-001 Jul 23, 2025
8691b19
fix
zhuqi-lucas-001 Jul 23, 2025
a5c7e9d
fxi
zhuqi-lucas-001 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 90 additions & 23 deletions datafusion/physical-plan/benches/aggregate_vectorized.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,27 @@ use datafusion_physical_plan::aggregates::group_values::multi_group_by::GroupCol
use std::sync::Arc;

const SIZES: [usize; 3] = [1_000, 10_000, 100_000];
const NULL_DENSITIES: [f32; 3] = [0.0, 0.1, 0.5];

fn bench_vectorized_append(c: &mut Criterion) {
let mut group = c.benchmark_group("ByteViewGroupValueBuilder_vectorized_append");
const NULL_DENSITIES: [f32; 4] = [0.0, 0.1, 0.5, 1.0];

fn bench_byte_view_group_operation(c: &mut Criterion) {
// test all inlined scenarios random from 0 ~ 12
for &size in &SIZES {
let mut group = c.benchmark_group("ByteViewGroupValueBuilder_inlined");

let rows: Vec<usize> = (0..size).collect();

for &null_density in &NULL_DENSITIES {
let input = create_string_view_array_with_len(size, null_density, 8, false);
let input = create_string_view_array_with_max_len(size, null_density, 12);
let input: ArrayRef = Arc::new(input);

// vectorized_append
let id = BenchmarkId::new(
format!("inlined_null_{null_density:.1}_size_{size}"),
"vectorized_append",
);
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
});
});
Expand All @@ -55,9 +56,9 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("inlined_null_{null_density:.1}_size_{size}"),
"append_val",
);
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
for &i in &rows {
builder.append_val(&input, i).unwrap();
}
Expand All @@ -69,18 +70,22 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("inlined_null_{null_density:.1}_size_{size}"),
"vectorized_equal_to",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
group.bench_function(id, |b| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
b.iter(|| {
builder.vectorized_equal_to(&rows, &input, &rows, &mut results);
});
});
}
group.finish();
}

// test mixed length from 0 ~ 64
for &size in &SIZES {
let mut group = c.benchmark_group("ByteViewGroupValueBuilder_mixed");
let rows: Vec<usize> = (0..size).collect();

for &null_density in &NULL_DENSITIES {
Expand All @@ -93,9 +98,65 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_append",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
builder.vectorized_append(&input, &rows).unwrap();
});
});

// append_val
let id = BenchmarkId::new(
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"append_val",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
for &i in &rows {
builder.append_val(&input, i).unwrap();
}
});
});

// vectorized_equal_to
let id = BenchmarkId::new(
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_equal_to",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
group.bench_function(id, |b| {
b.iter(|| {
builder.vectorized_equal_to(&rows, &input, &rows, &mut results);
});
});
}
group.finish();
}

// test fixed length 64
for &size in &SIZES {
let mut group = c.benchmark_group("ByteViewGroupValueBuilder_fixed");
let rows: Vec<usize> = (0..size).collect();

for &null_density in &NULL_DENSITIES {
let scenario = "fixed";
let input = create_string_view_array_with_len(size, null_density, 64, false);
let input: ArrayRef = Arc::new(input);

// vectorized_append
let id = BenchmarkId::new(
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_append",
);
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
});
});
Expand All @@ -105,9 +166,9 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"append_val",
);
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
for &i in &rows {
builder.append_val(&input, i).unwrap();
}
Expand All @@ -119,18 +180,22 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_equal_to",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
group.bench_function(id, |b| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
b.iter(|| {
builder.vectorized_equal_to(&rows, &input, &rows, &mut results);
});
});
}
group.finish();
}

// test random length from 0 ~ 400
for &size in &SIZES {
let mut group = c.benchmark_group("ByteViewGroupValueBuilder_random");
let rows: Vec<usize> = (0..size).collect();

for &null_density in &NULL_DENSITIES {
Expand All @@ -143,9 +208,10 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_append",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
});
});
Expand All @@ -155,9 +221,10 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"append_val",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
group.bench_function(id, |b| {
b.iter(|| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
for &i in &rows {
builder.append_val(&input, i).unwrap();
}
Expand All @@ -169,19 +236,19 @@ fn bench_vectorized_append(c: &mut Criterion) {
format!("{scenario}_null_{null_density:.1}_size_{size}"),
"vectorized_equal_to",
);

let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
group.bench_function(id, |b| {
let mut builder = ByteViewGroupValueBuilder::<StringViewType>::new();
builder.vectorized_append(&input, &rows).unwrap();
let mut results = vec![true; size];
b.iter(|| {
builder.vectorized_equal_to(&rows, &input, &rows, &mut results);
});
});
}
group.finish();
}

group.finish();
}

criterion_group!(benches, bench_vectorized_append);
criterion_group!(benches, bench_byte_view_group_operation);
criterion_main!(benches);