Skip to content

Conversation

zhuqi-lucas
Copy link

Which issue does this PR close?

Rationale for this change

Optimize vectorized append function

What changes are included in this PR?

Optimize vectorized append function

Are these changes tested?

critcmp  --filter "/vectorized_append" optimize_vectorized_append  main
group                                                                                         main                                    optimize_vectorized_append
-----                                                                                         ----                                    --------------------------
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_append      6.83      5.8±0.09µs        ? ?/sec     1.00   855.4±11.16ns        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_append     5.20     54.6±1.44µs        ? ?/sec     1.00     10.5±0.49µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_append    4.13   555.2±16.42µs        ? ?/sec     1.00    134.3±2.45µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_append      1.87     13.0±0.17µs        ? ?/sec     1.00      6.9±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_append     1.79   135.8±25.78µs        ? ?/sec     1.00     75.9±0.67µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_append    1.61  1317.2±57.35µs        ? ?/sec     1.00    815.9±4.39µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_append      1.37      9.7±0.29µs        ? ?/sec     1.00      7.1±0.31µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_append     1.25    153.5±8.49µs        ? ?/sec     1.00    122.8±1.29µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_append    1.14  1626.3±163.43µs        ? ?/sec    1.00  1430.9±52.95µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_append        2.65     14.3±0.22µs        ? ?/sec     1.00      5.4±0.17µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_append       2.11    154.3±1.54µs        ? ?/sec     1.00     73.0±0.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_append      4.11      3.4±0.08ms        ? ?/sec     1.00   825.8±19.57µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_append        2.30     18.7±0.25µs        ? ?/sec     1.00      8.1±0.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_append       2.30    222.3±2.05µs        ? ?/sec     1.00     96.4±1.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_append      2.11      2.5±0.08ms        ? ?/sec     1.00  1182.3±11.18µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_append        2.09     12.9±0.21µs        ? ?/sec     1.00      6.1±0.29µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_append       1.93    202.2±6.66µs        ? ?/sec     1.00    104.6±2.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_append      1.54      2.2±0.05ms        ? ?/sec     1.00   1436.8±8.23µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_append       1.09     18.8±0.43µs        ? ?/sec     1.00     17.3±0.89µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_append      1.14    250.9±2.93µs        ? ?/sec     1.00    220.5±5.58µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_append     1.00     11.6±1.11ms        ? ?/sec     1.00     11.6±1.02ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_append       1.22     21.1±0.36µs        ? ?/sec     1.00     17.3±0.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_append      1.26    289.4±3.34µs        ? ?/sec     1.00    230.1±5.77µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_append     1.09     11.2±0.29ms        ? ?/sec     1.00     10.2±0.90ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_append       1.26     14.6±0.24µs        ? ?/sec     1.00     11.5±0.12µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_append      1.44    257.5±4.17µs        ? ?/sec     1.00   178.8±11.30µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_append     1.16      7.1±0.25ms        ? ?/sec     1.00      6.2±0.18ms        ? ?/sec

Are there any user-facing changes?

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jul 23, 2025
@zhuqi-lucas
Copy link
Author

zhuqi-lucas commented Jul 23, 2025

Hi @alamb can you trigger the benchmark here, i can't believe the benchmark result from my local, thanks!

cargo bench --bench aggregate_vectorized "/vectorized_append"

critcmp  --filter "/vectorized_append" optimize_vectorized_append  main
group                                                                                         main                                    optimize_vectorized_append
-----                                                                                         ----                                    --------------------------
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_append      6.83      5.8±0.09µs        ? ?/sec     1.00   855.4±11.16ns        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_append     5.20     54.6±1.44µs        ? ?/sec     1.00     10.5±0.49µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_append    4.13   555.2±16.42µs        ? ?/sec     1.00    134.3±2.45µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_append      1.87     13.0±0.17µs        ? ?/sec     1.00      6.9±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_append     1.79   135.8±25.78µs        ? ?/sec     1.00     75.9±0.67µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_append    1.61  1317.2±57.35µs        ? ?/sec     1.00    815.9±4.39µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_append      1.37      9.7±0.29µs        ? ?/sec     1.00      7.1±0.31µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_append     1.25    153.5±8.49µs        ? ?/sec     1.00    122.8±1.29µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_append    1.14  1626.3±163.43µs        ? ?/sec    1.00  1430.9±52.95µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_append        2.65     14.3±0.22µs        ? ?/sec     1.00      5.4±0.17µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_append       2.11    154.3±1.54µs        ? ?/sec     1.00     73.0±0.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_append      4.11      3.4±0.08ms        ? ?/sec     1.00   825.8±19.57µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_append        2.30     18.7±0.25µs        ? ?/sec     1.00      8.1±0.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_append       2.30    222.3±2.05µs        ? ?/sec     1.00     96.4±1.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_append      2.11      2.5±0.08ms        ? ?/sec     1.00  1182.3±11.18µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_append        2.09     12.9±0.21µs        ? ?/sec     1.00      6.1±0.29µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_append       1.93    202.2±6.66µs        ? ?/sec     1.00    104.6±2.83µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_append      1.54      2.2±0.05ms        ? ?/sec     1.00   1436.8±8.23µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_append       1.09     18.8±0.43µs        ? ?/sec     1.00     17.3±0.89µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_append      1.14    250.9±2.93µs        ? ?/sec     1.00    220.5±5.58µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_append     1.00     11.6±1.11ms        ? ?/sec     1.00     11.6±1.02ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_append       1.22     21.1±0.36µs        ? ?/sec     1.00     17.3±0.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_append      1.26    289.4±3.34µs        ? ?/sec     1.00    230.1±5.77µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_append     1.09     11.2±0.29ms        ? ?/sec     1.00     10.2±0.90ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_append       1.26     14.6±0.24µs        ? ?/sec     1.00     11.5±0.12µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_append      1.44    257.5±4.17µs        ? ?/sec     1.00   178.8±11.30µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_append     1.16      7.1±0.25ms        ? ?/sec     1.00      6.2±0.18ms        ? ?/sec

@alamb alamb added the performance Make DataFusion faster label Jul 24, 2025
@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubuntu SMP Wed May 28 02:40:52 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing optimize_vectorized_append (e690f44) to 518fb4b diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

(I also queued up the mircobenchmark)

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖: Benchmark completed

Details

Comparing HEAD and optimize_vectorized_append
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ optimize_vectorized_append ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2019.08 ms │                 1983.36 ms │     no change │
│ QQuery 1     │   799.47 ms │                  744.28 ms │ +1.07x faster │
│ QQuery 2     │  1486.23 ms │                 1446.46 ms │     no change │
│ QQuery 3     │   682.78 ms │                  658.22 ms │     no change │
│ QQuery 4     │  1358.97 ms │                 1348.70 ms │     no change │
│ QQuery 5     │ 14505.76 ms │                14364.37 ms │     no change │
│ QQuery 6     │  2055.94 ms │                 2054.60 ms │     no change │
│ QQuery 7     │  1881.42 ms │                 1921.13 ms │     no change │
└──────────────┴─────────────┴────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                         ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                         │ 24789.64ms │
│ Total Time (optimize_vectorized_append)   │ 24521.12ms │
│ Average Time (HEAD)                       │  3098.70ms │
│ Average Time (optimize_vectorized_append) │  3065.14ms │
│ Queries Faster                            │          1 │
│ Queries Slower                            │          0 │
│ Queries with No Change                    │          7 │
│ Queries with Failure                      │          0 │
└───────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ optimize_vectorized_append ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.29 ms │                    2.37 ms │    no change │
│ QQuery 1     │    35.08 ms │                   34.09 ms │    no change │
│ QQuery 2     │    81.50 ms │                   80.30 ms │    no change │
│ QQuery 3     │   101.14 ms │                   97.59 ms │    no change │
│ QQuery 4     │   604.08 ms │                  589.09 ms │    no change │
│ QQuery 5     │   858.17 ms │                  869.38 ms │    no change │
│ QQuery 6     │     2.24 ms │                    2.27 ms │    no change │
│ QQuery 7     │    38.55 ms │                   39.05 ms │    no change │
│ QQuery 8     │   854.29 ms │                  860.17 ms │    no change │
│ QQuery 9     │  1172.60 ms │                 1208.72 ms │    no change │
│ QQuery 10    │   263.59 ms │                  258.22 ms │    no change │
│ QQuery 11    │   290.77 ms │                  285.25 ms │    no change │
│ QQuery 12    │   871.93 ms │                  881.71 ms │    no change │
│ QQuery 13    │  1240.79 ms │                 1262.15 ms │    no change │
│ QQuery 14    │   809.43 ms │                  819.75 ms │    no change │
│ QQuery 15    │   767.08 ms │                  790.94 ms │    no change │
│ QQuery 16    │  1563.95 ms │                 1573.91 ms │    no change │
│ QQuery 17    │  1562.25 ms │                 1567.96 ms │    no change │
│ QQuery 18    │  2808.79 ms │                 2805.20 ms │    no change │
│ QQuery 19    │    85.83 ms │                   88.86 ms │    no change │
│ QQuery 20    │  1135.01 ms │                 1176.02 ms │    no change │
│ QQuery 21    │  1286.62 ms │                 1340.08 ms │    no change │
│ QQuery 22    │  2108.01 ms │                 2193.74 ms │    no change │
│ QQuery 23    │  7451.92 ms │                 7508.48 ms │    no change │
│ QQuery 24    │   445.84 ms │                  444.66 ms │    no change │
│ QQuery 25    │   297.58 ms │                  309.06 ms │    no change │
│ QQuery 26    │   444.81 ms │                  444.84 ms │    no change │
│ QQuery 27    │  1535.51 ms │                 1570.58 ms │    no change │
│ QQuery 28    │ 12025.77 ms │                11988.03 ms │    no change │
│ QQuery 29    │   536.58 ms │                  526.83 ms │    no change │
│ QQuery 30    │   756.80 ms │                  801.63 ms │ 1.06x slower │
│ QQuery 31    │   800.50 ms │                  810.11 ms │    no change │
│ QQuery 32    │  2432.43 ms │                 2436.77 ms │    no change │
│ QQuery 33    │  3150.67 ms │                 3241.55 ms │    no change │
│ QQuery 34    │  3323.61 ms │                 3297.78 ms │    no change │
│ QQuery 35    │  1255.04 ms │                 1280.01 ms │    no change │
│ QQuery 36    │   118.79 ms │                  120.99 ms │    no change │
│ QQuery 37    │    52.61 ms │                   51.23 ms │    no change │
│ QQuery 38    │   118.43 ms │                  119.85 ms │    no change │
│ QQuery 39    │   190.34 ms │                  197.24 ms │    no change │
│ QQuery 40    │    42.34 ms │                   42.53 ms │    no change │
│ QQuery 41    │    37.27 ms │                   37.52 ms │    no change │
│ QQuery 42    │    32.95 ms │                   33.68 ms │    no change │
└──────────────┴─────────────┴────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                         ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                         │ 53593.77ms │
│ Total Time (optimize_vectorized_append)   │ 54090.17ms │
│ Average Time (HEAD)                       │  1246.37ms │
│ Average Time (optimize_vectorized_append) │  1257.91ms │
│ Queries Faster                            │          0 │
│ Queries Slower                            │          1 │
│ Queries with No Change                    │         42 │
│ Queries with Failure                      │          0 │
└───────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ optimize_vectorized_append ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1     │  98.34 ms │                   97.56 ms │    no change │
│ QQuery 2     │  19.81 ms │                   21.14 ms │ 1.07x slower │
│ QQuery 3     │  33.00 ms │                   32.49 ms │    no change │
│ QQuery 4     │  18.21 ms │                   18.53 ms │    no change │
│ QQuery 5     │  49.98 ms │                   50.70 ms │    no change │
│ QQuery 6     │  11.88 ms │                   11.92 ms │    no change │
│ QQuery 7     │  86.24 ms │                   88.99 ms │    no change │
│ QQuery 8     │  25.21 ms │                   24.98 ms │    no change │
│ QQuery 9     │  53.00 ms │                   53.90 ms │    no change │
│ QQuery 10    │  42.49 ms │                   42.18 ms │    no change │
│ QQuery 11    │  10.80 ms │                   10.87 ms │    no change │
│ QQuery 12    │  34.31 ms │                   34.85 ms │    no change │
│ QQuery 13    │  26.29 ms │                   25.82 ms │    no change │
│ QQuery 14    │   9.65 ms │                    9.77 ms │    no change │
│ QQuery 15    │  19.02 ms │                   19.47 ms │    no change │
│ QQuery 16    │  18.02 ms │                   17.71 ms │    no change │
│ QQuery 17    │  93.22 ms │                   95.71 ms │    no change │
│ QQuery 18    │ 195.02 ms │                  193.75 ms │    no change │
│ QQuery 19    │  25.19 ms │                   24.70 ms │    no change │
│ QQuery 20    │  30.77 ms │                   30.89 ms │    no change │
│ QQuery 21    │ 142.76 ms │                  144.11 ms │    no change │
│ QQuery 22    │  14.79 ms │                   15.00 ms │    no change │
└──────────────┴───────────┴────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                         ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                         │ 1058.00ms │
│ Total Time (optimize_vectorized_append)   │ 1065.05ms │
│ Average Time (HEAD)                       │   48.09ms │
│ Average Time (optimize_vectorized_append) │   48.41ms │
│ Queries Faster                            │         0 │
│ Queries Slower                            │         1 │
│ Queries with No Change                    │        21 │
│ Queries with Failure                      │         0 │
└───────────────────────────────────────────┴───────────┘

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubuntu SMP Wed May 28 02:40:52 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing optimize_vectorized_append (e690f44) to 518fb4b diff using: clickbench_1
Results will be posted here when complete

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖: Benchmark completed

Details

Comparing HEAD and optimize_vectorized_append
--------------------
Benchmark clickbench_1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ optimize_vectorized_append ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     0.58 ms │                    0.58 ms │     no change │
│ QQuery 1     │    77.04 ms │                   76.48 ms │     no change │
│ QQuery 2     │   108.87 ms │                  110.64 ms │     no change │
│ QQuery 3     │   135.76 ms │                  130.26 ms │     no change │
│ QQuery 4     │   680.35 ms │                  733.70 ms │  1.08x slower │
│ QQuery 5     │   863.66 ms │                  889.17 ms │     no change │
│ QQuery 6     │     0.66 ms │                    0.62 ms │ +1.06x faster │
│ QQuery 7     │    89.34 ms │                   85.02 ms │     no change │
│ QQuery 8     │   861.88 ms │                  910.20 ms │  1.06x slower │
│ QQuery 9     │  1187.99 ms │                 1208.07 ms │     no change │
│ QQuery 10    │   302.79 ms │                  290.57 ms │     no change │
│ QQuery 11    │   332.28 ms │                  322.72 ms │     no change │
│ QQuery 12    │   855.76 ms │                  901.32 ms │  1.05x slower │
│ QQuery 13    │  1182.40 ms │                 1230.83 ms │     no change │
│ QQuery 14    │   797.24 ms │                  813.67 ms │     no change │
│ QQuery 15    │   825.20 ms │                  816.59 ms │     no change │
│ QQuery 16    │  1600.98 ms │                 1582.12 ms │     no change │
│ QQuery 17    │  1605.30 ms │                 1578.35 ms │     no change │
│ QQuery 18    │  3016.20 ms │                 2850.91 ms │ +1.06x faster │
│ QQuery 19    │   129.59 ms │                  127.01 ms │     no change │
│ QQuery 20    │  1161.82 ms │                 1196.51 ms │     no change │
│ QQuery 21    │  1377.42 ms │                 1395.11 ms │     no change │
│ QQuery 22    │  2363.21 ms │                 2427.95 ms │     no change │
│ QQuery 23    │  8071.40 ms │                 8028.66 ms │     no change │
│ QQuery 24    │   471.26 ms │                  483.69 ms │     no change │
│ QQuery 25    │   342.62 ms │                  362.00 ms │  1.06x slower │
│ QQuery 26    │   467.88 ms │                  474.14 ms │     no change │
│ QQuery 27    │  1725.26 ms │                 1687.63 ms │     no change │
│ QQuery 28    │ 12325.47 ms │                12705.30 ms │     no change │
│ QQuery 29    │   566.97 ms │                  559.88 ms │     no change │
│ QQuery 30    │   797.85 ms │                  815.06 ms │     no change │
│ QQuery 31    │   844.70 ms │                  848.65 ms │     no change │
│ QQuery 32    │  2481.79 ms │                 2454.44 ms │     no change │
│ QQuery 33    │  3332.67 ms │                 3303.16 ms │     no change │
│ QQuery 34    │  3421.35 ms │                 3327.91 ms │     no change │
│ QQuery 35    │  1287.98 ms │                 1276.73 ms │     no change │
│ QQuery 36    │   178.23 ms │                  174.34 ms │     no change │
│ QQuery 37    │   109.35 ms │                  103.94 ms │     no change │
│ QQuery 38    │   180.27 ms │                  181.63 ms │     no change │
│ QQuery 39    │   259.00 ms │                  259.37 ms │     no change │
│ QQuery 40    │    88.94 ms │                   88.97 ms │     no change │
│ QQuery 41    │    85.37 ms │                   84.80 ms │     no change │
│ QQuery 42    │    74.15 ms │                   81.46 ms │  1.10x slower │
└──────────────┴─────────────┴────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                         ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                         │ 56668.78ms │
│ Total Time (optimize_vectorized_append)   │ 56980.14ms │
│ Average Time (HEAD)                       │  1317.88ms │
│ Average Time (optimize_vectorized_append) │  1325.12ms │
│ Queries Faster                            │          2 │
│ Queries Slower                            │          5 │
│ Queries with No Change                    │         36 │
│ Queries with Failure                      │          0 │
└───────────────────────────────────────────┴────────────┘

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖 ./gh_compare_branch_bench.sh Benchmark Script Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubuntu SMP Wed May 28 02:40:52 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing optimize_vectorized_append (e690f44) to 518fb4b diff
BENCH_NAME=aggregate_vectorized
BENCH_COMMAND=cargo bench --bench aggregate_vectorized
BENCH_FILTER=
BENCH_BRANCH_NAME=optimize_vectorized_append
Results will be posted here when complete

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

🤖: Benchmark completed

Details

group                                                                                           main                                   optimize_vectorized_append
-----                                                                                           ----                                   --------------------------
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/append_val               1.28      9.6±0.03µs        ? ?/sec    1.00      7.5±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_append        6.12      5.7±0.04µs        ? ?/sec    1.00    938.9±1.67ns        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_equal_to      1.00      9.3±0.02µs        ? ?/sec    1.03      9.6±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/append_val              1.23     91.0±0.25µs        ? ?/sec    1.00     73.9±0.32µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_append       6.08     54.9±0.20µs        ? ?/sec    1.00      9.0±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_equal_to     1.00     93.1±0.11µs        ? ?/sec    1.03     95.8±0.09µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/append_val             1.25    910.2±6.66µs        ? ?/sec    1.00    730.0±1.80µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_append      4.74    547.3±2.01µs        ? ?/sec    1.00    115.4±9.56µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_equal_to    1.00    937.1±1.21µs        ? ?/sec    1.03    964.8±1.30µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/append_val               1.40     13.3±0.04µs        ? ?/sec    1.00      9.5±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_append        2.03     13.8±0.05µs        ? ?/sec    1.00      6.8±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_equal_to      1.00     10.2±0.01µs        ? ?/sec    1.02     10.4±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/append_val              1.43    130.7±0.30µs        ? ?/sec    1.00     91.6±0.21µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_append       1.89    134.5±0.28µs        ? ?/sec    1.00     71.3±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_equal_to     1.00    101.3±0.17µs        ? ?/sec    1.02    103.7±0.09µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/append_val             1.41   1307.2±4.61µs        ? ?/sec    1.00    925.6±3.28µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_append      1.80   1353.2±3.15µs        ? ?/sec    1.00    753.2±8.15µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_equal_to    1.00   1024.3±7.26µs        ? ?/sec    1.02   1046.4±2.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/append_val               1.13     11.6±0.07µs        ? ?/sec    1.00     10.3±0.10µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_append        1.54     12.2±0.07µs        ? ?/sec    1.00      7.9±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_equal_to      1.00      7.3±0.02µs        ? ?/sec    1.02      7.5±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/append_val              1.07    139.3±0.87µs        ? ?/sec    1.00    130.2±0.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_append       1.31    144.5±0.52µs        ? ?/sec    1.00    110.1±0.33µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_equal_to     1.02     88.4±0.15µs        ? ?/sec    1.00     86.3±0.56µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/append_val             1.07   1419.0±6.24µs        ? ?/sec    1.00   1331.6±3.18µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_append      1.26   1465.8±5.74µs        ? ?/sec    1.00   1159.8±6.63µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_equal_to    1.03    915.4±2.71µs        ? ?/sec    1.00    892.3±1.58µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/append_val                 1.10     18.1±0.04µs        ? ?/sec    1.00     16.5±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_append          2.10     12.8±0.03µs        ? ?/sec    1.00      6.1±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_equal_to        1.00      8.2±0.02µs        ? ?/sec    1.02      8.4±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/append_val                1.10    186.7±0.60µs        ? ?/sec    1.00    169.6±0.82µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_append         2.09    146.7±0.61µs        ? ?/sec    1.00     70.3±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_equal_to       1.00     91.4±0.23µs        ? ?/sec    1.00     91.0±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/append_val               1.07      4.0±0.05ms        ? ?/sec    1.00      3.7±0.03ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_append        4.62      3.5±0.05ms        ? ?/sec    1.00    766.6±4.97µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_equal_to      1.00    990.3±3.91µs        ? ?/sec    1.01    999.0±3.13µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/append_val                 1.20     20.0±0.08µs        ? ?/sec    1.00     16.7±0.05µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_append          2.20     20.2±0.11µs        ? ?/sec    1.00      9.2±0.03µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_equal_to        1.00      9.1±0.03µs        ? ?/sec    1.01      9.2±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/append_val                1.13    220.1±0.61µs        ? ?/sec    1.00    194.6±0.43µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_append         1.95    222.2±0.65µs        ? ?/sec    1.00    113.8±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_equal_to       1.00    101.6±0.31µs        ? ?/sec    1.02    104.0±0.25µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/append_val               1.13      2.4±0.01ms        ? ?/sec    1.00      2.1±0.01ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_append        2.07      2.4±0.01ms        ? ?/sec    1.00   1166.5±2.92µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_equal_to      1.00   1110.7±3.94µs        ? ?/sec    1.01   1123.7±2.81µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/append_val                 1.08     14.5±0.18µs        ? ?/sec    1.00     13.4±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_append          2.25     15.0±0.10µs        ? ?/sec    1.00      6.7±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_equal_to        1.00      6.4±0.01µs        ? ?/sec    1.02      6.6±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/append_val                1.05    188.2±0.48µs        ? ?/sec    1.00    178.5±0.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_append         1.54    189.8±0.42µs        ? ?/sec    1.00    123.0±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_equal_to       1.00     94.3±0.42µs        ? ?/sec    1.00     94.7±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/append_val               1.08  1996.7±10.57µs        ? ?/sec    1.00   1853.9±4.97µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_append        1.52      2.0±0.01ms        ? ?/sec    1.00   1329.0±3.75µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_equal_to      1.01   1064.2±2.62µs        ? ?/sec    1.00   1056.0±5.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/append_val                1.15     23.1±0.46µs        ? ?/sec    1.00     20.2±0.12µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_append         1.25     19.2±0.46µs        ? ?/sec    1.00     15.3±0.15µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_equal_to       1.00     12.2±0.07µs        ? ?/sec    1.00     12.2±0.05µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/append_val               1.00    249.3±1.71µs        ? ?/sec    1.46    365.0±4.91µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_append        1.14    222.4±3.00µs        ? ?/sec    1.00    194.9±4.60µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_equal_to      1.00    165.8±4.55µs        ? ?/sec    1.02    168.6±7.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/append_val              1.02     14.7±0.25ms        ? ?/sec    1.00     14.4±0.26ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_append       1.12     14.2±0.24ms        ? ?/sec    1.00     12.7±0.24ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_equal_to     1.03      3.7±0.06ms        ? ?/sec    1.00      3.6±0.05ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/append_val                1.05     21.7±0.29µs        ? ?/sec    1.00     20.6±0.21µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_append         1.44     23.9±0.50µs        ? ?/sec    1.00     16.6±0.17µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_equal_to       1.00     11.8±0.07µs        ? ?/sec    1.02     12.0±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/append_val               1.00    276.9±2.91µs        ? ?/sec    1.38    382.7±1.72µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_append        1.32    277.5±1.55µs        ? ?/sec    1.00    209.5±2.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_equal_to      1.00    172.7±4.76µs        ? ?/sec    1.00    172.9±5.08µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/append_val              1.04     13.9±0.22ms        ? ?/sec    1.00     13.3±0.23ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_append       1.19     14.1±0.25ms        ? ?/sec    1.00     11.8±0.21ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_equal_to     1.01      3.5±0.07ms        ? ?/sec    1.00      3.5±0.06ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/append_val                1.00     17.6±0.18µs        ? ?/sec    1.02     17.9±0.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_append         1.51     17.6±0.23µs        ? ?/sec    1.00     11.6±0.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_equal_to       1.00      7.9±0.04µs        ? ?/sec    1.03      8.1±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/append_val               1.01    246.3±1.85µs        ? ?/sec    1.00    244.3±1.22µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_append        1.42    250.3±2.07µs        ? ?/sec    1.00    176.3±0.47µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_equal_to      1.00    144.1±0.85µs        ? ?/sec    1.00    144.3±0.82µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/append_val              1.05      8.7±0.19ms        ? ?/sec    1.00      8.3±0.19ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_append       1.28      8.7±0.17ms        ? ?/sec    1.00      6.8±0.23ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_equal_to     1.03      2.1±0.03ms        ? ?/sec    1.00      2.1±0.03ms        ? ?/sec

@zhuqi-lucas
Copy link
Author

🤖: Benchmark completed

Details

group                                                                                           main                                   optimize_vectorized_append
-----                                                                                           ----                                   --------------------------
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/append_val               1.28      9.6±0.03µs        ? ?/sec    1.00      7.5±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_append        6.12      5.7±0.04µs        ? ?/sec    1.00    938.9±1.67ns        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_1000/vectorized_equal_to      1.00      9.3±0.02µs        ? ?/sec    1.03      9.6±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/append_val              1.23     91.0±0.25µs        ? ?/sec    1.00     73.9±0.32µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_append       6.08     54.9±0.20µs        ? ?/sec    1.00      9.0±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_10000/vectorized_equal_to     1.00     93.1±0.11µs        ? ?/sec    1.03     95.8±0.09µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/append_val             1.25    910.2±6.66µs        ? ?/sec    1.00    730.0±1.80µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_append      4.74    547.3±2.01µs        ? ?/sec    1.00    115.4±9.56µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.0_size_100000/vectorized_equal_to    1.00    937.1±1.21µs        ? ?/sec    1.03    964.8±1.30µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/append_val               1.40     13.3±0.04µs        ? ?/sec    1.00      9.5±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_append        2.03     13.8±0.05µs        ? ?/sec    1.00      6.8±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_1000/vectorized_equal_to      1.00     10.2±0.01µs        ? ?/sec    1.02     10.4±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/append_val              1.43    130.7±0.30µs        ? ?/sec    1.00     91.6±0.21µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_append       1.89    134.5±0.28µs        ? ?/sec    1.00     71.3±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_10000/vectorized_equal_to     1.00    101.3±0.17µs        ? ?/sec    1.02    103.7±0.09µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/append_val             1.41   1307.2±4.61µs        ? ?/sec    1.00    925.6±3.28µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_append      1.80   1353.2±3.15µs        ? ?/sec    1.00    753.2±8.15µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.1_size_100000/vectorized_equal_to    1.00   1024.3±7.26µs        ? ?/sec    1.02   1046.4±2.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/append_val               1.13     11.6±0.07µs        ? ?/sec    1.00     10.3±0.10µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_append        1.54     12.2±0.07µs        ? ?/sec    1.00      7.9±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_1000/vectorized_equal_to      1.00      7.3±0.02µs        ? ?/sec    1.02      7.5±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/append_val              1.07    139.3±0.87µs        ? ?/sec    1.00    130.2±0.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_append       1.31    144.5±0.52µs        ? ?/sec    1.00    110.1±0.33µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_10000/vectorized_equal_to     1.02     88.4±0.15µs        ? ?/sec    1.00     86.3±0.56µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/append_val             1.07   1419.0±6.24µs        ? ?/sec    1.00   1331.6±3.18µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_append      1.26   1465.8±5.74µs        ? ?/sec    1.00   1159.8±6.63µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/inlined_null_0.5_size_100000/vectorized_equal_to    1.03    915.4±2.71µs        ? ?/sec    1.00    892.3±1.58µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/append_val                 1.10     18.1±0.04µs        ? ?/sec    1.00     16.5±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_append          2.10     12.8±0.03µs        ? ?/sec    1.00      6.1±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_1000/vectorized_equal_to        1.00      8.2±0.02µs        ? ?/sec    1.02      8.4±0.01µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/append_val                1.10    186.7±0.60µs        ? ?/sec    1.00    169.6±0.82µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_append         2.09    146.7±0.61µs        ? ?/sec    1.00     70.3±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_10000/vectorized_equal_to       1.00     91.4±0.23µs        ? ?/sec    1.00     91.0±0.19µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/append_val               1.07      4.0±0.05ms        ? ?/sec    1.00      3.7±0.03ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_append        4.62      3.5±0.05ms        ? ?/sec    1.00    766.6±4.97µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.0_size_100000/vectorized_equal_to      1.00    990.3±3.91µs        ? ?/sec    1.01    999.0±3.13µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/append_val                 1.20     20.0±0.08µs        ? ?/sec    1.00     16.7±0.05µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_append          2.20     20.2±0.11µs        ? ?/sec    1.00      9.2±0.03µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_1000/vectorized_equal_to        1.00      9.1±0.03µs        ? ?/sec    1.01      9.2±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/append_val                1.13    220.1±0.61µs        ? ?/sec    1.00    194.6±0.43µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_append         1.95    222.2±0.65µs        ? ?/sec    1.00    113.8±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_10000/vectorized_equal_to       1.00    101.6±0.31µs        ? ?/sec    1.02    104.0±0.25µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/append_val               1.13      2.4±0.01ms        ? ?/sec    1.00      2.1±0.01ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_append        2.07      2.4±0.01ms        ? ?/sec    1.00   1166.5±2.92µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.1_size_100000/vectorized_equal_to      1.00   1110.7±3.94µs        ? ?/sec    1.01   1123.7±2.81µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/append_val                 1.08     14.5±0.18µs        ? ?/sec    1.00     13.4±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_append          2.25     15.0±0.10µs        ? ?/sec    1.00      6.7±0.04µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_1000/vectorized_equal_to        1.00      6.4±0.01µs        ? ?/sec    1.02      6.6±0.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/append_val                1.05    188.2±0.48µs        ? ?/sec    1.00    178.5±0.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_append         1.54    189.8±0.42µs        ? ?/sec    1.00    123.0±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_10000/vectorized_equal_to       1.00     94.3±0.42µs        ? ?/sec    1.00     94.7±0.35µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/append_val               1.08  1996.7±10.57µs        ? ?/sec    1.00   1853.9±4.97µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_append        1.52      2.0±0.01ms        ? ?/sec    1.00   1329.0±3.75µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/mixed_null_0.5_size_100000/vectorized_equal_to      1.01   1064.2±2.62µs        ? ?/sec    1.00   1056.0±5.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/append_val                1.15     23.1±0.46µs        ? ?/sec    1.00     20.2±0.12µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_append         1.25     19.2±0.46µs        ? ?/sec    1.00     15.3±0.15µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_1000/vectorized_equal_to       1.00     12.2±0.07µs        ? ?/sec    1.00     12.2±0.05µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/append_val               1.00    249.3±1.71µs        ? ?/sec    1.46    365.0±4.91µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_append        1.14    222.4±3.00µs        ? ?/sec    1.00    194.9±4.60µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_10000/vectorized_equal_to      1.00    165.8±4.55µs        ? ?/sec    1.02    168.6±7.02µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/append_val              1.02     14.7±0.25ms        ? ?/sec    1.00     14.4±0.26ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_append       1.12     14.2±0.24ms        ? ?/sec    1.00     12.7±0.24ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.0_size_100000/vectorized_equal_to     1.03      3.7±0.06ms        ? ?/sec    1.00      3.6±0.05ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/append_val                1.05     21.7±0.29µs        ? ?/sec    1.00     20.6±0.21µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_append         1.44     23.9±0.50µs        ? ?/sec    1.00     16.6±0.17µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_1000/vectorized_equal_to       1.00     11.8±0.07µs        ? ?/sec    1.02     12.0±0.11µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/append_val               1.00    276.9±2.91µs        ? ?/sec    1.38    382.7±1.72µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_append        1.32    277.5±1.55µs        ? ?/sec    1.00    209.5±2.51µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_10000/vectorized_equal_to      1.00    172.7±4.76µs        ? ?/sec    1.00    172.9±5.08µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/append_val              1.04     13.9±0.22ms        ? ?/sec    1.00     13.3±0.23ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_append       1.19     14.1±0.25ms        ? ?/sec    1.00     11.8±0.21ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.1_size_100000/vectorized_equal_to     1.01      3.5±0.07ms        ? ?/sec    1.00      3.5±0.06ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/append_val                1.00     17.6±0.18µs        ? ?/sec    1.02     17.9±0.16µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_append         1.51     17.6±0.23µs        ? ?/sec    1.00     11.6±0.27µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_1000/vectorized_equal_to       1.00      7.9±0.04µs        ? ?/sec    1.03      8.1±0.06µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/append_val               1.01    246.3±1.85µs        ? ?/sec    1.00    244.3±1.22µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_append        1.42    250.3±2.07µs        ? ?/sec    1.00    176.3±0.47µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_10000/vectorized_equal_to      1.00    144.1±0.85µs        ? ?/sec    1.00    144.3±0.82µs        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/append_val              1.05      8.7±0.19ms        ? ?/sec    1.00      8.3±0.19ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_append       1.28      8.7±0.17ms        ? ?/sec    1.00      6.8±0.23ms        ? ?/sec
ByteViewGroupValueBuilder_vectorized_append/random_null_0.5_size_100000/vectorized_equal_to     1.03      2.1±0.03ms        ? ?/sec    1.00      2.1±0.03ms        ? ?/sec

Thank you @alamb , it is almost the same result from my local. But the clickbench/tpch seems no change.

@alamb
Copy link
Contributor

alamb commented Jul 24, 2025

Thank you @alamb , it is almost the same result from my local. But the clickbench/tpch seems no change.

Yeah, I was hoping to see some end to end performance improvements too. I'll try and look carefully at this PR over the next day or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Make DataFusion faster physical-plan Changes to the physical-plan crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants