[Fix](Exception) Fix potential use-after-free because Exception::to_string is not thread safe
#59558
+11
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
force-pushed
the
remove-cached-string-in-Exception
branch
from
0d90f21 to
df5240f
Compare
bobhan1
force-pushed
the
remove-cached-string-in-Exception
branch
from
df5240f to
394140e
Compare
yiguolei
approved these changes
Jan 5, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 31449 ms |
TPC-DS: Total hot run time: 173109 ms |
ClickBench: Total hot run time: 26.93 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run nonConcurrent |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
…string` is not thread safe (#59558) ### What problem does this PR solve? Problem Summary: `Exception::to_string()` may by accessed concurrently in the following situation: - thread A and thread B access the same `DorisCallOnce` object - An Exception `e` is throw when thread A is calling `DorisCallOnce::call` and `e` is thrown to thread A - `e` will be also thrown to thread B later by DorisCallOnce - thread A and thread B access `Exception::to_string()` concurrently This may cause use-after-free due to the assignment of `_cache_string` in `Exception::to_string` Considering that `Exception` should not be frequently used, this PR construct `_cache_string` in constructor `Exception::Exception` rather than lazily creating it. This can avoid additional unnessary synchronazation. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Exception::to_string()may by accessed concurrently in the following situation:DorisCallOnceobjecteis throw when thread A is callingDorisCallOnce::callandeis thrown to thread Aewill be also thrown to thread B later by DorisCallOnceException::to_string()concurrentlyThis may cause use-after-free due to the assignment of
_cache_stringinException::to_stringConsidering that
Exceptionshould not be frequently used, this PR construct_cache_stringin constructorException::Exceptionrather than lazily creating it. This can avoid additional unnessary synchronazation.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)