Skip to content

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented Jan 5, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@csun5285
Copy link
Contributor Author

csun5285 commented Jan 5, 2026

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 31280 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f80975c810d7d86365a723975e817e165071fc2, data reload: false

------ Round 1 ----------------------------------
q1	17655	4282	4069	4069
q2	2077	362	254	254
q3	10092	1253	707	707
q4	10216	831	311	311
q5	7509	2096	1812	1812
q6	184	169	139	139
q7	939	778	653	653
q8	9271	1339	1116	1116
q9	4864	4493	4604	4493
q10	6748	1819	1405	1405
q11	506	291	291	291
q12	692	728	588	588
q13	17793	3827	3063	3063
q14	296	290	277	277
q15	595	507	503	503
q16	695	665	622	622
q17	673	744	554	554
q18	6698	6414	6360	6360
q19	1227	955	609	609
q20	412	357	254	254
q21	3008	2483	2229	2229
q22	1017	1000	971	971
Total cold run time: 103167 ms
Total hot run time: 31280 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4142	4039	4056	4039
q2	325	388	325	325
q3	2094	2572	2232	2232
q4	1290	1729	1320	1320
q5	4128	4014	4034	4014
q6	212	174	131	131
q7	1857	1745	1627	1627
q8	2803	2448	2527	2448
q9	7353	7176	7229	7176
q10	2650	3035	2221	2221
q11	556	481	455	455
q12	683	771	654	654
q13	3729	4071	3330	3330
q14	299	330	304	304
q15	554	520	524	520
q16	643	689	635	635
q17	1183	1366	1306	1306
q18	8048	7788	7913	7788
q19	992	857	839	839
q20	1993	2087	1970	1970
q21	4792	4579	4297	4297
q22	1141	1062	1072	1062
Total cold run time: 51467 ms
Total hot run time: 48693 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173650 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f80975c810d7d86365a723975e817e165071fc2, data reload: false

query5	4817	587	437	437
query6	324	227	226	226
query7	4227	444	265	265
query8	332	242	237	237
query9	8767	2660	2670	2660
query10	517	369	318	318
query11	15122	15002	14798	14798
query12	168	126	112	112
query13	1256	486	376	376
query14	6386	2943	2701	2701
query14_1	2660	2655	2635	2635
query15	201	194	170	170
query16	1032	486	443	443
query17	1072	666	570	570
query18	2540	438	349	349
query19	230	219	200	200
query20	124	117	114	114
query21	215	138	119	119
query22	3848	4146	3884	3884
query23	16845	16280	15780	15780
query23_1	15839	15875	15961	15875
query24	7548	1539	1163	1163
query24_1	1183	1196	1222	1196
query25	520	446	369	369
query26	1232	267	148	148
query27	2773	426	277	277
query28	4587	2130	2144	2130
query29	755	527	425	425
query30	304	233	197	197
query31	802	608	544	544
query32	74	64	61	61
query33	537	324	271	271
query34	899	880	525	525
query35	718	787	697	697
query36	838	839	808	808
query37	124	92	75	75
query38	2671	2665	2598	2598
query39	771	762	727	727
query39_1	703	722	706	706
query40	215	128	111	111
query41	64	58	57	57
query42	102	93	96	93
query43	431	438	427	427
query44	1316	723	717	717
query45	182	178	170	170
query46	843	959	581	581
query47	1382	1463	1395	1395
query48	309	326	239	239
query49	604	411	320	320
query50	630	264	202	202
query51	3823	3852	3657	3657
query52	107	106	94	94
query53	293	329	267	267
query54	285	251	236	236
query55	75	76	71	71
query56	284	278	291	278
query57	1070	1015	964	964
query58	275	243	239	239
query59	2136	2062	2092	2062
query60	313	314	292	292
query61	162	164	162	162
query62	381	384	304	304
query63	292	262	267	262
query64	4904	1311	998	998
query65	3849	3722	3747	3722
query66	1402	409	286	286
query67	15553	15533	15682	15533
query68	6693	998	700	700
query69	494	348	328	328
query70	1028	881	934	881
query71	372	294	271	271
query72	6055	3486	3518	3486
query73	768	718	308	308
query74	8820	8939	8599	8599
query75	2814	2782	2426	2426
query76	3905	1043	639	639
query77	500	366	259	259
query78	9628	9816	9264	9264
query79	1368	890	583	583
query80	609	571	478	478
query81	520	264	224	224
query82	214	142	108	108
query83	262	252	239	239
query84	260	122	104	104
query85	906	505	462	462
query86	383	298	293	293
query87	2826	2858	2709	2709
query88	3607	2226	2220	2220
query89	383	348	327	327
query90	2198	148	144	144
query91	170	177	147	147
query92	87	67	64	64
query93	1643	877	525	525
query94	579	322	298	298
query95	560	316	301	301
query96	581	473	206	206
query97	2313	2349	2294	2294
query98	225	207	194	194
query99	591	565	514	514
Total cold run time: 255242 ms
Total hot run time: 173650 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.03 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f80975c810d7d86365a723975e817e165071fc2, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.04	0.05
query3	0.26	0.09	0.09
query4	1.62	0.12	0.11
query5	0.27	0.26	0.25
query6	1.15	0.66	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.56	0.49	0.50
query10	0.54	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.59	0.58	0.59
query14	0.96	0.95	0.95
query15	0.79	0.78	0.78
query16	0.43	0.42	0.41
query17	1.04	1.03	0.98
query18	0.23	0.21	0.21
query19	1.96	1.91	1.89
query20	0.02	0.01	0.01
query21	15.48	0.29	0.15
query22	5.04	0.05	0.05
query23	16.03	0.30	0.10
query24	0.97	0.45	0.29
query25	0.08	0.08	0.08
query26	0.17	0.13	0.13
query27	0.06	0.07	0.06
query28	3.37	1.05	0.89
query29	12.55	3.90	3.21
query30	0.30	0.15	0.13
query31	2.82	0.62	0.40
query32	3.23	0.56	0.46
query33	2.98	3.00	3.07
query34	16.69	5.14	4.45
query35	4.48	4.48	4.52
query36	0.65	0.49	0.50
query37	0.12	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 96.43 s
Total hot run time: 27.03 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.21% (18961/35637)
Line Coverage 39.20% (175935/448801)
Region Coverage 33.71% (136037/403594)
Branch Coverage 34.69% (58732/169308)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (25/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.18% (25145/34838)
Line Coverage 58.95% (263860/447583)
Region Coverage 53.92% (219830/407714)
Branch Coverage 55.40% (94103/169857)

@yiguolei yiguolei merged commit 54d012e into apache:master Jan 6, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x-conflict reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants