-
Notifications
You must be signed in to change notification settings - Fork 3.7k
add function hamming distance #59568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhishengyk
wants to merge
5
commits into
apache:master
Choose a base branch
from
zhishengyk:feat/hamming-distance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Author
|
run buildall |
This commit introduces the hamming_distance scalar function. Includes: - BE implementation and unit tests. - FE function definition and visitor logic. - End-to-end regression tests.
Author
|
run buildall |
Author
|
run buildall |
TPC-H: Total hot run time: 31837 ms |
TPC-DS: Total hot run time: 172259 ms |
ClickBench: Total hot run time: 26.86 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hamming_distance function to calculate the Hamming distance between two strings.
Changes
BE: Implement hamming_distance in function_string.cpp with FunctionBinaryToType + HammingDistanceImpl,
and raise an error when the two input strings have different lengths instead of returning NULL.
FE: Add HammingDistance scalar function in Nereids with AlwaysNullable (returns NULL when any input is NULL).
Test: Add BE-UT with check_function_all_arg_comb to cover all argument combinations.
Test: Add distributed regression test test_hamming_distance.groovy.
Doc: [link to your doc PR in apache/doris-website].
Behavior
Return type: BIGINT, the number of positions where corresponding characters differ.
Returns NULL if any input is NULL.
Throws an error if the two strings have different lengths.
Works for vector/vector, scalar/vector, vector/scalar, scalar/scalar combinations.
Testing
BE-UT: ./run-be-ut.sh (pass).
Regression: ./run-regression-test.sh --run test_hamming_distance (pass).