Fix/issue 15798 graceful shutdown #15973
Open
+99
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrlw
reviewed
Jan 7, 2026
| ModuleModel moduleModel = DubboBeanUtils.getModuleModel(context); | ||
| Assertions.assertFalse(moduleModel.isDestroyed(), "Module should be running"); | ||
|
|
||
| System.out.println("Closing context..."); |
Contributor
There was a problem hiding this comment.
- should use log.info (log4j2.xml) instead of System.out.XXX
- code format issue should be fixed by
mvn spotless:apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fixes #15798.
Problem:
In Spring Boot applications, Dubbo currently destroys the ModuleModel immediately upon receiving the ContextClosedEvent. This causes a race condition where other beans (e.g., scheduled tasks or other
DisposableBeanimplementations) that are still destroying themselves may try to call Dubbo services, resulting inRpcException: Directory of type RegistryDirectory already destroyed for service.Solution:
Refactored DubboDeployApplicationListener to implement
DisposableBeanand moved the destruction logic from onContextClosedEvent to the destroy() method. This defers Dubbo's shutdown until the bean destruction phase, ensuring that other beans have time to complete their cleanup while Dubbo services are still available, effectively supporting a graceful shutdown.Checklist