[FLINK-38247] Handle BIGINT UNSIGNED overflow in PreparedStatement #4117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.cdc.connectors.mysql.source.utils; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.lang.reflect.Proxy; | ||
| import java.math.BigInteger; | ||
| import java.sql.PreparedStatement; | ||
| import java.sql.SQLException; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** Unit test for {@link org.apache.flink.cdc.connectors.mysql.source.utils.StatementUtils}. */ | ||
| class StatementUtilsTest { | ||
|
|
||
| @Test | ||
| void testSetSafeObjectCorrectlyHandlesOverflow() throws SQLException { | ||
| Map<String, Object> invocationDetails = new HashMap<>(); | ||
| PreparedStatement psProxy = createPreparedStatementProxy(invocationDetails); | ||
|
|
||
| long overflowValue = Long.MAX_VALUE + 1L; | ||
| BigInteger expectedBigInteger = new BigInteger(Long.toUnsignedString(overflowValue)); | ||
|
|
||
| // Use the safe method | ||
| StatementUtils.setSafeObject(psProxy, 1, overflowValue); | ||
|
|
||
| // Assert that it correctly used setObject with the converted BigInteger value | ||
| assertThat(invocationDetails.get("methodName")).isEqualTo("setObject"); | ||
| assertThat(invocationDetails.get("value")).isInstanceOf(BigInteger.class); | ||
| assertThat(invocationDetails.get("value")).isEqualTo(expectedBigInteger); | ||
| } | ||
|
|
||
| @Test | ||
| void testDirectSetObjectFailsOnOverflow() throws SQLException { | ||
| Map<String, Object> invocationDetails = new HashMap<>(); | ||
| PreparedStatement psProxy = createPreparedStatementProxy(invocationDetails); | ||
|
|
||
| long overflowValue = Long.MAX_VALUE + 1L; | ||
|
|
||
| // Directly call the unsafe method on the proxy | ||
| psProxy.setObject(1, overflowValue); | ||
|
|
||
| // Assert that it incorrectly used setObject, preserving the wrong negative long value | ||
| assertThat(invocationDetails.get("methodName")).isEqualTo("setObject"); | ||
| assertThat(invocationDetails.get("value")).isInstanceOf(Long.class); | ||
| assertThat(invocationDetails.get("value")).isEqualTo(Long.MIN_VALUE); | ||
| } | ||
|
|
||
| @Test | ||
| void testSetSafeObjectHandlesRegularValues() throws SQLException { | ||
| Map<String, Object> invocationDetails = new HashMap<>(); | ||
| PreparedStatement psProxy = createPreparedStatementProxy(invocationDetails); | ||
|
|
||
| // Test with a common Long | ||
| StatementUtils.setSafeObject(psProxy, 1, 123L); | ||
| assertThat(invocationDetails.get("methodName")).isEqualTo("setObject"); | ||
| assertThat(invocationDetails.get("value")).isEqualTo(123L); | ||
| invocationDetails.clear(); | ||
|
|
||
| // Test with a String | ||
| StatementUtils.setSafeObject(psProxy, 2, "test"); | ||
| assertThat(invocationDetails.get("methodName")).isEqualTo("setObject"); | ||
| assertThat(invocationDetails.get("value")).isEqualTo("test"); | ||
| invocationDetails.clear(); | ||
|
|
||
| // Test with null | ||
| StatementUtils.setSafeObject(psProxy, 3, null); | ||
| assertThat(invocationDetails.get("methodName")).isEqualTo("setObject"); | ||
| assertThat(invocationDetails.get("value")).isNull(); | ||
| invocationDetails.clear(); | ||
| } | ||
|
|
||
| private PreparedStatement createPreparedStatementProxy(Map<String, Object> invocationDetails) { | ||
| return (PreparedStatement) | ||
| Proxy.newProxyInstance( | ||
| StatementUtilsTest.class.getClassLoader(), | ||
| new Class<?>[] {PreparedStatement.class}, | ||
| (proxy, method, args) -> { | ||
| String methodName = method.getName(); | ||
| if (methodName.equals("setObject")) { | ||
| invocationDetails.put("methodName", methodName); | ||
| invocationDetails.put("parameterIndex", args[0]); | ||
| invocationDetails.put("value", args[1]); | ||
| } | ||
| return null; | ||
| }); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be BigInteger type, you can verify this in itcase.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of sql lists for possible test case:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvyanquan
Hello! I added itcase in MySqlSourceITCase.
I think JDBC may surface BIGINT UNSIGNED as Long (values > Long.MAX_VALUE appear negative due to two’s complement)
So In this code, 1) detect negative Longs 2) bind them as BigInteger, ensuring values near 2^64−1 are handled correctly.
I Added an IT in MySqlSourceITCase that creates unsigned_bigint_pk and verifies boundary values. And I saw that the test worked well.