[FLINK-38478][pipeline-connector][paimon] Generate a random commit user and store it in state. #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and store it in state.
|
Hi @yuxiqian, PTAL. |
yuxiqian
reviewed
Oct 16, 2025
There was a problem hiding this comment.
Thanks for @lvyanquan's nice work! Just left some comments here.
|
|
||
| @ParameterizedTest(name = "{0} -> SNAPSHOT") | ||
| @EnumSource(names = {"V3_2_1", "V3_3_0", "SNAPSHOT"}) | ||
| @EnumSource(names = {"V3_2_1", "V3_3_0", "V3_4_0", "SNAPSHOT"}) |
There was a problem hiding this comment.
We may add 3.5.0 into the matrix now
| this.catalogOptions = catalogOptions; | ||
| this.commitUser = commitUser; | ||
| // generate a random commit user to avoid conflict. | ||
| this.commitUser = commitUser + UUID.randomUUID(); |
There was a problem hiding this comment.
Can we introduce commit.user-prefix as an alias of commit.user? Paimon also uses this option name, and I think it describes how commitUser is created better.
| } | ||
|
|
||
| @ParameterizedTest(name = "{0} -> SNAPSHOT") | ||
| @EnumSource(names = {"V3_2_1", "V3_3_0", "V3_4_0", "SNAPSHOT"}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a random commit user and store it in state to avoid data loss.