Skip to content

Conversation

@pratapaditya04
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Add Jar Cache Directory Validation with Fallback
    Summary
    Implements validation for jar cache directories with automatic fallback handling in GobblinYarnAppLauncher.
    Changes
    Added addJarCachingConfig() method: Validates JAR_CACHE_DIR exists on filesystem, falls back to FALLBACK_JAR_CACHE_DIR if not found, or disables jar caching if neither exists

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Comment on lines 1078 to 1079
return config.withValue(GobblinYarnConfigurationKeys.JAR_CACHE_DIR,
ConfigValueFactory.fromAnyRef(fullPath));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computing JAR_CACHE_DIR from filesystem state at config load time makes it hard to debug. We can introduce a JarCachePathResolver instead that computes the resolved cache dir, when needed.

If that's too big a change, for now, let's check that JAR_CACHE_DIR is not already explicitly configured(if it is, use it as is) to avoid overriding an existing config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, removed logic from constructor , made JarCachePathResolver

@pratapaditya04 pratapaditya04 force-pushed the jar_caching_dir branch 2 times, most recently from a3a1a43 to 098498a Compare December 17, 2025 14:13
@Blazer-007 Blazer-007 merged commit 4ee5b3e into apache:master Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants