fix(catalog/rest): Handle decoding errors from non-200 responses #529
+29
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a simple example without having setup my catalog URI correctly. This code snippet:
errored with
Turns out, when the catalog is returning a non-200 response, we never check for decoding errors which is why we get the unhelpful
": "
error.In this PR, I've refactored the
func handleNon200
a little bit to accommodate this. The code is now instead returning something like"decoding json response: EOF: REST error: server error"
. I have a corresponding commit that shows this new behavior, it's not yet included in this PR because it's a bit clunky.