Skip to content

Conversation

rambleraptor
Copy link
Contributor

Rationale for this change

The Java implementation has several tests around updating Table Specs. This adds three of them to the Python Catalog Tests.

Are these changes tested?

Tests should pass.

Are there any user-facing changes?

Just tests.

Copy link
Contributor

@gabeiglio gabeiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some small comments 👍🏼.

@kevinjqliu
Copy link
Contributor

Looks like this caught a bug! Thanks @gabeiglio for fixing it in #2489.

Could you try to rebase this PR?

@rambleraptor rambleraptor force-pushed the partition_sort_evolution_tests branch from 1306663 to c29c29c Compare September 22, 2025 22:11
@rambleraptor
Copy link
Contributor Author

@kevinjqliu rebased!

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a few nit comments. Thanks for adding these tests :)
the add then remove one was a surprise to me

@rambleraptor rambleraptor force-pushed the partition_sort_evolution_tests branch 2 times, most recently from b7410ef to 9384139 Compare October 7, 2025 21:05
@Fokko
Copy link
Contributor

Fokko commented Oct 12, 2025

@rambleraptor Thanks for adding this, can you fix the merge conflicts?

@rambleraptor rambleraptor force-pushed the partition_sort_evolution_tests branch from 9384139 to 544e9be Compare October 12, 2025 23:52
@rambleraptor
Copy link
Contributor Author

@Fokko merge conflicts fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants