Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py::StreamsUpgradeT
```
* Run tests with a specific image name
```
image_name="ducker-ak-openjdk:17-buster" bash tests/docker/run_tests.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for another, perhaps we could use openjdk:17 for this example to avoid using the explicit os version.

image_name="ducker-ak-openjdk:17-bullseye" bash tests/docker/run_tests.sh
```
* Run tests with a different JVM
```
bash tests/docker/ducker-ak up -j 'openjdk:17-buster'; tests/docker/run_tests.sh
bash tests/docker/ducker-ak up -j 'openjdk:17-bullseye'; tests/docker/run_tests.sh
```
* Remove ducker-ak containers
```
Expand Down
4 changes: 2 additions & 2 deletions tests/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
# limitations under the License.

# The base image of openjdk:17 is typically oraclelinux:8-slim, which doesn't include apt-get.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment should be moved to ducker-ak

# Therefore, use openjdk:17-buster instead.
ARG jdk_version=openjdk:17-buster
# Therefore, use openjdk:17-bullseye instead.
ARG jdk_version=openjdk:17-bullseye
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the default value here since we are taking that from the build script where we also have a default value?

If we also update the README.md using a placeholder (e.g. <JDK_IMAGE>), in the next base image update we would only need to update the default image name in one place. Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

FROM $jdk_version AS build-native-image

WORKDIR /build
Expand Down
2 changes: 1 addition & 1 deletion tests/docker/ducker-ak
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ docker_run_memory_limit="2000m"
default_num_nodes=14

# The default OpenJDK base image.
default_jdk="openjdk:17-buster"
default_jdk="openjdk:17-bullseye"

# The default ducker-ak image name.
default_image_name="ducker-ak"
Expand Down