-
Notifications
You must be signed in to change notification settings - Fork 14.6k
KAFKA-19501: Update OpenJDK base image from buster to bullseye #20165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
da2c6a8
5d62424
297209b
f6a5219
4880171
3f45d09
ebcb35b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,8 @@ | |
# limitations under the License. | ||
|
||
# The base image of openjdk:17 is typically oraclelinux:8-slim, which doesn't include apt-get. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this comment should be moved to |
||
# Therefore, use openjdk:17-buster instead. | ||
ARG jdk_version=openjdk:17-buster | ||
# Therefore, use openjdk:17-bullseye instead. | ||
ARG jdk_version=openjdk:17-bullseye | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we remove the default value here since we are taking that from the build script where we also have a default value? If we also update the README.md using a placeholder (e.g. <JDK_IMAGE>), in the next base image update we would only need to update the default image name in one place. Wdyt? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sounds good |
||
FROM $jdk_version AS build-native-image | ||
|
||
WORKDIR /build | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for another, perhaps we could use
openjdk:17
for this example to avoid using the explicit os version.