KAFKA-9965/KAFKA-13303: RoundRobinPartitioner broken by KIP-480 #20170
+202
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
producer
clients
small
| partitioner.onNewBatch(topicB, testCluster, 1); | ||
| assertEquals(7, partitioner.partition(topicA, null, null, null, null, testCluster)); | ||
| assertEquals(8, partitioner.partition(topicA, null, null, null, null, testCluster)); | ||
| assertEquals(1, partitioner.partition(topicB, null, null, null, null, testCluster)); |
There was a problem hiding this comment.
It's great that this test verifies the next partition selected matches the enqueued value for each topic. Consider adding test cases for some edge cases, like empty queue and error handling
There was a problem hiding this comment.
Hello @ash-at-github,
Thanks for this suggestion. I've added a test case for the empty queue scenario.
Let me know if you have more questions.
jim0987795064
changed the title
chia7712
reviewed
Jul 30, 2025
| @@ -45,4 +45,7 @@ public interface Partitioner extends Configurable, Closeable { | |||
| * This is called when partitioner is closed. | |||
| */ | |||
| void close(); | |||
|
|
|||
| default void onNewBatch(String topic, Cluster cluster, int prevPartition) { | |||
There was a problem hiding this comment.
please consider using "casting" to invoke RoundRobinPartitioner#onNewBatch if needs
…est for empty partition queue
…65/KAFKA-13303-trunk-backport
jim0987795064
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoundRobinPartitioner behaviour was broken by sticky partitioning
(KIP-480).
This patch addresses the behavioural issue caused by the second call to
partition()afteronNewBatch(), in a predicatable and thread-safemanner.
Unit tested by simulation of multiple threads producing to two topics
with race conditions.
Changes:
ensures thread-safety across multiple producer threads.
topics.
Reasons:
can result in multiple threads assigning the same partition for new
batches. This breaks the intended even distribution and causes partition
skew.