MINOR: Remove duplicate renewTimePeriodOpt in DelegationTokenCommand validation #20177
+140
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>
Yunyung
reviewed
Jul 16, 2025
frankvicky
reviewed
Jul 17, 2025
m1a2st
approved these changes
Jul 22, 2025
github-actions
bot
added
streams
core
dalaoqi
force-pushed
the
remove-duplicate-renewTimePeriodOpt
branch
from
4076dbf to
98cbc0a
Compare
Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>
Comment on lines
+148
to
+149
| String[] args = {"--bootstrap-server", "localhost:9092", "--command-config", "testfile", "--create", "--max-life-time-period", "604800000", "--hmac", "test-hmac"}; | ||
| DelegationTokenCommand.DelegationTokenCommandOptions opts = new DelegationTokenCommand.DelegationTokenCommandOptions(args); |
There was a problem hiding this comment.
For --create command, --renew-time-period and --expiry-time-period are invalid arguments as well. Could you also add them to the case? We also need similar update for different commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was a duplicate parameter validation in the
DelegationTokenCommandclass. ThecheckInvalidArgsmethod for thedescribeOptwas incorrectly includingrenewTimePeriodOpttwice inthe set of invalid arguments.
This bug will cause the unexpected command error like the picture below
