MINOR: Remove duplicate renewTimePeriodOpt in DelegationTokenCommand validation #20177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>
Yunyung
reviewed
Jul 16, 2025
frankvicky
reviewed
Jul 17, 2025
m1a2st
approved these changes
Jul 22, 2025
github-actions
bot
added
streams
core
dalaoqi
force-pushed
the
remove-duplicate-renewTimePeriodOpt
branch
from
4076dbf to
98cbc0a
Compare
Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>
Comment on lines
148
to
149
| String[] args = {"--bootstrap-server", "localhost:9092", "--command-config", "testfile", "--create", "--max-life-time-period", "604800000", "--hmac", "test-hmac"}; | ||
| DelegationTokenCommand.DelegationTokenCommandOptions opts = new DelegationTokenCommand.DelegationTokenCommandOptions(args); |
There was a problem hiding this comment.
For --create command, --renew-time-period and --expiry-time-period are invalid arguments as well. Could you also add them to the case? We also need similar update for different commands.
…sts and add missing cases Signed-off-by: Tsung-Han Ho (Miles Ho) <mystes3016@gmail.com>
chia7712
reviewed
Jul 31, 2025
|
|
||
| String[] argsDescribeMissingConfig = {"--bootstrap-server", "localhost:9092", "--describe"}; | ||
| DelegationTokenCommand.DelegationTokenCommandOptions optsDescribeMissingConfig = new DelegationTokenCommand.DelegationTokenCommandOptions(argsDescribeMissingConfig); | ||
| assertThrows(RuntimeException.class, () -> optsDescribeMissingConfig.checkArgs()); |
There was a problem hiding this comment.
Please use optsDescribeMissingConfig::checkArgs instead
chia7712
approved these changes
Jul 31, 2025
chia7712
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
LGTM
the e2e gets pass on my local.
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id: 2025-07-31--001
run time: 52.090 seconds
tests run: 1
passed: 1
flaky: 0
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.core.delegation_token_test.DelegationTokenTest.test_delegation_token_lifecycle.metadata_quorum=ISOLATED_KRAFT
status: PASS
run time: 51.960 seconds
--------------------------------------------------------------------------------
chia7712
approved these changes
Aug 3, 2025
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Aug 6, 2025
…validation (apache#20177) The bug was a duplicate parameter validation in the `DelegationTokenCommand` class. The `checkInvalidArgs` method for the `describeOpt` was incorrectly including `renewTimePeriodOpt` twice in the set of invalid arguments. This bug caused unexpected command errors during E2E testing. ### Before the fix: The following command would fail due to the duplicate validation logic: ``` TC_PATHS="tests/kafkatest/tests/core/delegation_token_test.py::DelegationTokenTest" /bin/bash tests/docker/run_tests.sh ``` ### Error output: ``` ducktape.cluster.remoteaccount.RemoteCommandError: ducker@ducker03: Command 'KAFKA_OPTS="-Djava.security.auth.login.config=/mnt/security/jaas.conf -Djava.security.krb5.conf=/mnt/security/krb5.conf" /opt/kafka-dev/bin/kafka-delegation-tokens.sh --bootstrap-server ducker03:9094 --create --max-life-time-period -1 --command-config /mnt/kafka/client.properties > /mnt/kafka/delegation_token.out' returned non-zero exit status 1. Remote error message: b'duplicate element: [renew-time-period]\njava.lang.IllegalArgumentException: duplicate element: [renew-time-period]\n\tat java.base/java.util.ImmutableCollections$SetN.<init>(ImmutableCollections.java:918)\n\tat java.base/java.util.Set.of(Set.java:544)\n\tat org.apache.kafka.tools.DelegationTokenCommand$DelegationTokenCommandOptions.checkArgs(DelegationTokenCommand.java:304)\n\tat org.apache.kafka.tools.DelegationTokenCommand.execute(DelegationTokenCommand.java:79)\n\tat org.apache.kafka.tools.DelegationTokenCommand.mainNoExit(DelegationTokenCommand.java:57)\n\tat org.apache.kafka.tools.DelegationTokenCommand.main(DelegationTokenCommand.java:52)\n\n' [INFO:2025-07-31 11:27:25,531]: RunnerClient: kafkatest.tests.core.delegation_token_test.DelegationTokenTest.test_delegation_token_lifecycle.metadata_quorum=ISOLATED_KRAFT: Data: None ================================================================================ SESSION REPORT (ALL TESTS) ducktape version: 0.12.0 session_id: 2025-07-31--002 run time: 33.213 seconds tests run: 1 passed: 0 flaky: 0 failed: 1 ignored: 0 ================================================================================ test_id: kafkatest.tests.core.delegation_token_test.DelegationTokenTest.test_delegation_token_lifecycle.metadata_quorum=ISOLATED_KRAFT status: FAIL run time: 33.090 seconds ``` ### After the fix: The same command now executes successfully: ``` TC_PATHS="tests/kafkatest/tests/core/delegation_token_test.py::DelegationTokenTest" /bin/bash tests/docker/run_tests.sh ``` ### Success output: ``` ================================================================================ SESSION REPORT (ALL TESTS) ducktape version: 0.12.0 session_id: 2025-07-31--001 run time: 35.488 seconds tests run: 1 passed: 1 flaky: 0 failed: 0 ignored: 0 ================================================================================ test_id: kafkatest.tests.core.delegation_token_test.DelegationTokenTest.test_delegation_token_lifecycle.metadata_quorum=ISOLATED_KRAFT status: PASS run time: 35.363 seconds -------------------------------------------------------------------------------- ``` Reviewers: Jhen-Yung Hsu <jhenyunghsu@gmail.com>, TengYao Chi <frankvicky@apache.org>, Ken Huang <s7133700@gmail.com>, PoAn Yang <payang@apache.org>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was a duplicate parameter validation in the
DelegationTokenCommandclass. ThecheckInvalidArgsmethod for thedescribeOptwas incorrectly includingrenewTimePeriodOpttwice inthe set of invalid arguments.
This bug caused unexpected command errors during E2E testing.
Before the fix:
The following command would fail due to the duplicate validation logic:
Error output:
After the fix:
The same command now executes successfully:
Success output:
Reviewers: Jhen-Yung Hsu jhenyunghsu@gmail.com, TengYao Chi
frankvicky@apache.org, Ken Huang s7133700@gmail.com, PoAn Yang
payang@apache.org, Chia-Ping Tsai chia7712@gmail.com