KAFKA-19516: Added a request timeout of 120000ms to CreateTopics in ShareFetchAcknolwedgeRequestTest methods #20184
+215
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
@chirag-wadhwa5 Can you pelase link the flaky test failure here, I cheked here and can see flakiness. But it's for some other reason than you mentioned. |
…rs in GroupCoordinatorBaseRequestTest after the topic creation
smjn
reviewed
Jul 17, 2025
| @@ -131,8 +132,15 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) { | |||
| controllers = controllerServers(), | |||
There was a problem hiding this comment.
instead of the timeout - could we do something like waitUntilTrue? Basically I want retries instead on one long call.
There was a problem hiding this comment.
Thanks for the review. I have made this change, and now the call TestUtils.createTopicWithAdmin is made inside a waitUntilTrue
m1a2st
reviewed
Jul 22, 2025
Comment on lines
+145
to
+147
| msg = "Failed to create topic with admin within 2 minutes", | ||
| waitTimeMs = 2 * 60 * 1000, // 2 minutes in milliseconds | ||
| pause = 40 * 1000 // 40 seconds in milliseconds |
There was a problem hiding this comment.
Just out of curiosity, why does the CreateTopic operation sometimes take up to 2 minutes to succeed? Is there a configuration that controls this behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works is an aim to resolve the flakiness in the ShareFetchAcknolwedgeRequestTest tests. Recently some flakes were seen on the test and it was reproduced locally as well, with the error ->
Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment. Call: createTopics. This PR tries to resolve that by adding an increased timeout of 120000ms (2 minutes) to the CreateTopics request sent out.