Skip to content

Cherrypick "MINOR : Handle error for client telemetry push (#19881)" #20195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Cherrypick "MINOR : Handle error for client telemetry push (#19881)" #20195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...ts/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,15 +709,22 @@ private Optional<Builder<?>> createPushRequest(ClientTelemetrySubscription local
}

CompressionType compressionType = ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
ByteBuffer buffer = ClientTelemetryUtils.compress(payload, compressionType);
ByteBuffer compressedPayload;
try {
compressedPayload = ClientTelemetryUtils.compress(payload, compressionType);
} catch (Throwable e) {
log.debug("Failed to compress telemetry payload for compression: {}, sending uncompressed data", compressionType);
compressedPayload = ByteBuffer.wrap(payload);
compressionType = CompressionType.NONE;
}

AbstractRequest.Builder<?> requestBuilder = new PushTelemetryRequest.Builder(
new PushTelemetryRequestData()
.setClientInstanceId(localSubscription.clientInstanceId())
.setSubscriptionId(localSubscription.subscriptionId())
.setTerminating(terminating)
.setCompressionType(compressionType.id)
.setMetrics(Utils.readBytes(buffer)), true);
.setMetrics(Utils.readBytes(compressedPayload)), true);

return Optional.of(requestBuilder);
}
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public PushTelemetryResponse processPushTelemetryRequest(PushTelemetryRequest re
if (metrics != null && metrics.length > 0) {
try {
receiverPlugin.exportMetrics(requestContext, request);
} catch (Exception exception) {
dd } catch (Throwable exception) {
clientInstance.lastKnownError(Errors.INVALID_RECORD);
return request.errorResponse(0, Errors.INVALID_RECORD);
}
Expand Down