-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-19503: Deprecate MX4j support #20208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This feature adds maintenance burden and potential security concerns while providing no apparent value to the Kafka community. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fvaleri: Thanks for the patch.
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI pass.
Do we need to specify that the removal time will be 5.0 instead of the next major release?
We have both approaches in the previous release notes, but I would follow the kip and mention the exact release version. |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Failed tests are not related to the patch. |
This feature adds maintenance burden and potential security concerns
while providing no apparent value to the Kafka community. See
KIP-1193 for more
details.
Reviewers: TengYao Chi frankvicky@apache.org, Ken Huang
s7133700@gmail.com