-
Notifications
You must be signed in to change notification settings - Fork 140
Advised and Enforced Management #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Any idea about memory/perfs implications of the switch to |
|
Did not perf measure it yet, but obviously will have some impact: none of code change affect long living objects, except the DefaultDependencyNode, where instead of All the rest of code changes is either very short living (DependencyManagement, PremanagedDependency) objects, or no effect like in case of DependencyManager instances... |
Originally, dependency management marked a "subject" as "managed", it was 0/1 true/false only. This PR now adds ability to mark management as "advised" (may be subjected to further management) or "enforced" (equivalent of previously "managed").
Changes:
DependencyManagerapplies management as "enforced", if they come from root (ie. project POM), otherwise as "advice" (this latter applies to transitive managers only, as for example classic manager have no data from "deeper levels").ConflictManagerbacks out for enforced scope/optionality.