Skip to content

Conversation

@kassane
Copy link
Contributor

@kassane kassane commented Oct 14, 2024

Requirements

How to work D Binding?

importC read opendal.h on <root_dir>/bindings/c/include to auto-generate a binding.
Note: the pragma attribute(push,nogc,nothrow) is new feature (not released yet).
https://dlang.org/changelog/pending.html#dmd.importc-pragma-stc

Note

Currently, cbindgen PR hasn't been merged to support D. So I've ruled out using the fork. But that doesn't stop me from using the current solution.

cc: @Xuanwo

@kassane kassane requested review from PsiACE and Xuanwo as code owners October 14, 2024 20:49
@kassane kassane force-pushed the d-binding branch 2 times, most recently from 761ff8c to f98f0e3 Compare October 15, 2024 12:24
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kassane, thank you so much for your efforts on this! I've never written in D before, so I'm unable to offer detailed advice. However, I've left some suggestions regarding the public API; please have a look.

@kassane kassane force-pushed the d-binding branch 2 times, most recently from 80bd29b to 2c418ef Compare October 16, 2024 17:15
@kassane kassane requested a review from Xuanwo October 16, 2024 17:22
@kassane

This comment was marked as resolved.

@kassane kassane changed the title D bindings support feat(bindings/swift): add D bindings support Oct 17, 2024
@kassane kassane changed the title feat(bindings/swift): add D bindings support feat(bindings/d): add D bindings support Oct 17, 2024
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Oct 17, 2024
@kassane kassane force-pushed the d-binding branch 2 times, most recently from 1a9b85d to 7ddea57 Compare October 21, 2024 14:23
@kassane
Copy link
Contributor Author

kassane commented Oct 21, 2024

Rebased, single commit!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thank you @kassane for working on this.

* `std.paralellism` support added (write/read/list)
* CI/CD test
* rename `is_exists` - ref.: apache#5199

Signed-off-by: Matheus C. França  <matheus-catarino@hotmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kassane for working on this! I believe it's a good start point. Would you like to share this with Dlang community to collect some feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants