-
Notifications
You must be signed in to change notification settings - Fork 43
HDDS-9616. Add downloads page #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HDDS-9225-website-v2
Are you sure you want to change the base?
Conversation
|
Release note pages are 404. Not sure if you intended to add them. |
|
hi @kerneltime
Do you mean the http://localhost:3001/release-notes endpoint? |
|
Headers have been added to the release notes to indicate that they are no longer maintained. The logic has been implemented to:
The release notes remain in the same directory, no changes were made to the folder structure. |
ivandika3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the download page. Overall LGTM.
Just need to add download links for 2.0.0 and I think we're good to go. The release notes can be handled under HDDS-9617.
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from my original comment on the Jira I'm still not seeing what we gain by having this metadata in the front matter instead of just linking the pages in the correct part of the table.
The supported version information and release date should be displayed in the table, and on the actual release page itself. If there's a way to automate both of these from the front matter then maybe this is the way to go. But if the information still needs to be duplicated in the rendered markdown of each release page then we are still tracking it in two places.
If we do have some sort of automation, we should embed the javascript in download.mdx instead of making it all javascript. mdx will allow us to only automate the necessary parts while leaving the plain text around it easily editable as markdown.
What changes were proposed in this pull request?
HDDS-9616. Add downloads page
Please describe your PR in detail:
What is the link to the Apache Jira?
HDDS-9616. Add downloads page
How was this patch tested?
Check off which of the following tests were done on this change. If additional testing was done, please elaborate here as well.