-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-13870. Bare Metal Ozone Installer with support for multiple node deployment. #9247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
IMHO it would be better to implement installer in python or go, I'm not sure if it would be easy to maintain/extend over the time. |
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it. |
|
@yandrey321 - Refactored the code to ansible. |
| line += f"# line: {lineno}\n" | ||
| if role_name: | ||
| line += f"# role: {role_name}\n" | ||
| with open(self._out_file, "w", encoding="utf-8") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use logger instead of writing directly to the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a persisted file that is used by the next rerun and I don't think logger is the right choice for such use cases.
I don't see any problem with "with open" for handling persisted file.
Let me know if you still feel there is an issue with using above way of writing file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to implement state machine please use state machine FW.
What changes were proposed in this pull request?
HDDS-13870: Bare Metal Ozone Installer with support for multiple node deployment.
Please describe your PR in detail:
Single node support
HA mode support
Service User creation
Passwordless SSH
JAVA 17/21 Configure Installation
What is the link to the Apache JIRA
HDDS-13870
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Deployed Debian 3 node cluster and tested the installation.
Triggered via Python script :