Skip to content

HDDS-14259. Improve TestManagedDirectSlice. #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
szetszwo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

HDDS-14259. Improve TestManagedDirectSlice. #9571

szetszwo wants to merge 3 commits into from
+43 −15

Conversation

@szetszwo
Copy link
Contributor

@szetszwo szetszwo commented Dec 29, 2025

What changes were proposed in this pull request?

  • The offset, which is not useful anymore after HDDS-14237, should be removed.
  • The hardcoded test cases are too simple: too few and all the sizes are power of 2. We should test some random sizes.

What is the link to the Apache JIRA

HDDS-14259

How was this patch tested?

This is a test only change.

@szetszwo szetszwo requested a review from swamirishi December 29, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swamirishi swamirishi Awaiting requested review from swamirishi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@szetszwo