Skip to content

Conversation

@priyeshkaratha
Copy link
Contributor

@priyeshkaratha priyeshkaratha commented Jan 2, 2026

What changes were proposed in this pull request?

Currently, JmxServiceProviderImpl fails to fetch JMX metrics when Datanodes are configured with Kerberos authentication. This occurs because the ReconUtils#makeHttpCall method is invoked without the isSpnego flag set to true, causing authentication to fail.
This PR introduces a check for the hdds.datanode.http.auth.type configuration property. If set to kerberos, the service will now correctly pass isSpnego = true to ReconUtils, ensuring secure JMX communication.

What is the link to the Apache JIRA

HDDS-14334

How was this patch tested?

Validated with CI

@priyeshkaratha priyeshkaratha marked this pull request as ready for review January 2, 2026 08:34
Copy link
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @priyeshkaratha .

@priyeshkaratha priyeshkaratha changed the title HDDS-14334. Fix JMX query failures when hdds.datanode.http.auth.type is set to Kerberos HDDS-14334. [DO NOT MERGE] Fix JMX query failures when hdds.datanode.http.auth.type is set to Kerberos Jan 5, 2026
@adoroszlai
Copy link
Contributor

Thanks @priyeshkaratha for the patch. Why is this marked as "DO NOT MERGE"?

@priyeshkaratha
Copy link
Contributor Author

@adoroszlai current code is not setting security context properly. I just updated the PR with changes and tested in one of the ycloud cluster.

@priyeshkaratha priyeshkaratha changed the title HDDS-14334. [DO NOT MERGE] Fix JMX query failures when hdds.datanode.http.auth.type is set to Kerberos HDDS-14334. Fix JMX query failures when hdds.datanode.http.auth.type is set to Kerberos Jan 5, 2026
@ChenSammi ChenSammi merged commit 7c40dde into apache:master Jan 5, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants