HDDS-14236. Fix BackgroundService to follow scheduleWithFixedDelay semantics #9595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
changed the title
ChenSammi
reviewed
Jan 8, 2026
| LOG.info("Starting service {} with interval {} {}", serviceName, | ||
| interval, unit.name().toLowerCase()); | ||
| exec.scheduleWithFixedDelay(service, 0, interval, unit); | ||
| scheduler.scheduleWithFixedDelay(service, 0, interval, unit); |
Contributor
There was a problem hiding this comment.
@xichen01 , thanks for continue this improvement task.
Can we keep using the exec here? What's the extra benefit of introducing scheduler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Context
If a
BackgroundServicetask takes longer than the interval, the next task will be executed immediately after the previous task completes.For previous discussion #9185
Current PR Fix BackgroundService to make it follow scheduleWithFixedDelay mantics.
Implementation:
Moving
future.join();fromBackgroundService#PeriodicalTask#runto after task submission, and usingfuture.join();to wait for all submitted tasks to complete, effectively transformsPeriodicalTask#runinto a blocking function. This enables it to execute according to thescheduleWithFixedDelaypattern.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14236
How was this patch tested?
unit test.