[spark] Optimize exception message in checkNamespace method #6384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
reviewed
Oct 13, 2025
| public class CatalogUtils { | ||
|
|
||
| public static void checkNamespace(String[] namespace) { | ||
| public static void checkNamespace(String[] namespace, String catalogName) { |
There was a problem hiding this comment.
Can you try spark.sessionState.catalogManager.currentCatalog.name to get catalog name
| checkArgument( | ||
| namespace.length == 1, | ||
| "Paimon only support single namespace, but got %s", | ||
| "Current catalog is %s, catalog %s does not exist or Paimon only support single namespace, but got %s", |
There was a problem hiding this comment.
Please add a test case for this
kerwin-zk
force-pushed
the
fix-exception-message
branch
from
02e7d4a to
de733b7
Compare
Zouxxyy
reviewed
Oct 13, 2025
|
|
||
| public static void checkNamespace(String[] namespace) { | ||
| String catalogName = | ||
| SparkSession.getActiveSession() |
There was a problem hiding this comment.
Use PaimonSparkSession.active
kerwin-zk
force-pushed
the
fix-exception-message
branch
2 times, most recently
from
010f2df to
92635a3
Compare
kerwin-zk
force-pushed
the
fix-exception-message
branch
from
92635a3 to
9943048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Optimize exception message in checkNamespace method
Tests
CI