[python] Remove all redundant changes in pr 6969 #6977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
leaves12138
changed the title
JingsongLi
reviewed
Jan 8, 2026
| # Generate partition statistics for the commit | ||
| statistics = self._generate_partition_statistics(commit_entries) | ||
| except Exception as e: | ||
| self._cleanup_preparation_failure(new_manifest_file, delta_manifest_list, |
JingsongLi
reviewed
Jan 8, 2026
| result = self._try_commit_once( | ||
| retry_result=retry_result, | ||
| commit_kind=commit_kind, | ||
| commit_entries=commit_entries, |
Contributor
There was a problem hiding this comment.
pass a function, overwrite commit should generate commit_entries by snapshot.
leaves12138
changed the title
JingsongLi
reviewed
Jan 8, 2026
| + f"with identifier {commit_identifier} and kind {commit_kind}." | ||
| ) | ||
| return SuccessResult() | ||
| def _cleanup_preparation_failure(self, manifest_file: Optional[str], |
Contributor
There was a problem hiding this comment.
Why pass manifest_file? delta_manifest_list already contains this file?
leaves12138
changed the title
JingsongLi
reviewed
Jan 8, 2026
| latest_snapshot: Optional[Snapshot]) -> CommitResult: | ||
| start_time_ms = int(time.time() * 1000) | ||
|
|
||
| if retry_result is not None and latest_snapshot is not None: |
Contributor
There was a problem hiding this comment.
Keep this as it is, and add test to verify this.
JingsongLi
reviewed
Jan 8, 2026
| commit_entries=None, # Will be generated in _try_commit based on latest snapshot | ||
| commit_identifier=commit_identifier | ||
| commit_identifier=commit_identifier, | ||
| commit_entries_plan=lambda snapshot: self._generate_overwrite_entries(snapshot) |
Contributor
There was a problem hiding this comment.
remove self._overwrite_partition_filter and self._overwrite_commit_messages.
JingsongLi
reviewed
Jan 8, 2026
| latest_snapshot: Optional[Snapshot]) -> CommitResult: | ||
| start_time_ms = int(time.time() * 1000) | ||
|
|
||
| if retry_result is not None and latest_snapshot is not None: |
Contributor
There was a problem hiding this comment.
extract a method for this.
JingsongLi
reviewed
Jan 8, 2026
| if retry_result.latest_snapshot is not None: | ||
| start_check_snapshot_id = retry_result.latest_snapshot.id + 1 | ||
|
|
||
| for snapshot_id in range(start_check_snapshot_id, latest_snapshot.id + 2): |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation